Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1586763009: Revert of [DevTools] Added base SourceMap implementation on backend (Closed)

Created:
4 years, 11 months ago by samuong
Modified:
4 years, 11 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Added base SourceMap implementation on backend (patchset #9 id:180001 of https://codereview.chromium.org/1574133002/ ) Reason for revert: looks like this is causing a compile failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20Builder/builds/335 Original issue's description: > [DevTools] Added base SourceMap implementation on backend > > This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps. > > BUG=341082 > R=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org > > Committed: https://crrev.com/3136a502672cbdae1cc51c93b5ab3b79e778416d > Cr-Commit-Position: refs/heads/master@{#369618} TBR=lushnikov@chromium.org,pfeldman@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=341082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -504 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/SourceMap.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp View 1 chunk +0 lines, -263 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp View 1 chunk +0 lines, -183 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
samuong
Created Revert of [DevTools] Added base SourceMap implementation on backend
4 years, 11 months ago (2016-01-15 00:12:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586763009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586763009/1
4 years, 11 months ago (2016-01-15 00:12:42 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp: While running git rm third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp; fatal: pathspec 'third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp' did ...
4 years, 11 months ago (2016-01-15 00:14:05 UTC) #4
kozy
4 years, 11 months ago (2016-01-15 23:35:43 UTC) #7
Message was sent while issue was closed.
It was reverted in https://codereview.chromium.org/1588053004/

Powered by Google App Engine
This is Rietveld 408576698