Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1586723003: Fix a bad cast in PaintLayerClipper (Closed)

Created:
4 years, 11 months ago by leviw_travelin_and_unemployed
Modified:
4 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bad cast in PaintLayerClipper Fix a bad cast in PaintLayerClipper (inline->box). Chris and I discussed offline and decided to bail on clipping of inlines entirely for now, pending more discussion with Tab. BUG=570561 Committed: https://crrev.com/833e60a214c8d888ea828e627159150a2e46e1d9 Cr-Commit-Position: refs/heads/master@{#369664}

Patch Set 1 #

Patch Set 2 : Fix build #

Total comments: 1

Patch Set 3 : Revert inline flow changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
A + third_party/WebKit/LayoutTests/fast/css/containment/inline-paint-containment-crash.html View 1 chunk +1 line, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/css/containment/inline-paint-containment-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
leviw_travelin_and_unemployed
4 years, 11 months ago (2016-01-14 01:57:44 UTC) #2
chrishtr
https://codereview.chromium.org/1586723003/diff/20001/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp File third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp (right): https://codereview.chromium.org/1586723003/diff/20001/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp#newcode231 third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp:231: paintBoxShadowAndFillLayers(paintInfo, *styleToUse, adjustedFrameRect); Why is it just box shadow ...
4 years, 11 months ago (2016-01-14 18:32:56 UTC) #3
leviw_travelin_and_unemployed
4 years, 11 months ago (2016-01-14 23:40:30 UTC) #5
chrishtr
On 2016/01/14 at 23:40:30, leviw wrote: > Update: we discussed offline and decided to bail ...
4 years, 11 months ago (2016-01-14 23:56:55 UTC) #6
chrishtr
lgtm
4 years, 11 months ago (2016-01-14 23:57:00 UTC) #8
leviw_travelin_and_unemployed
On 2016/01/14 at 23:56:55, chrishtr wrote: > On 2016/01/14 at 23:40:30, leviw wrote: > > ...
4 years, 11 months ago (2016-01-14 23:57:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586723003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586723003/40001
4 years, 11 months ago (2016-01-14 23:58:25 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-15 02:37:20 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 02:38:41 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/833e60a214c8d888ea828e627159150a2e46e1d9
Cr-Commit-Position: refs/heads/master@{#369664}

Powered by Google App Engine
This is Rietveld 408576698