Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1586683003: Revert of NaCl: Update revision in DEPS, 26c7e6a -> c4c237c (Closed)

Created:
4 years, 11 months ago by vasilii
Modified:
4 years, 11 months ago
CC:
chromium-reviews, erikchen, Roland McGrath, Mark Seaborn, native-client-reviews_googlegroups.com, petarj, Jim Stichnoth, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, 26c7e6a -> c4c237c (patchset #1 id:1 of https://codereview.chromium.org/1580293003/ ) Reason for revert: Broke nacl_integration on Mac10.6 Tests. https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/10932 dyld: Library not loaded: /usr/lib/libc++.1.dylib Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang Reason: image not found /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/stubs/socket.o src/untrusted/nacl/stubs/socket.c scons: *** [scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o] Error -5 ... scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o failed: Error -5 And many similar messages Original issue's description: > NaCl: Update revision in DEPS, 26c7e6a -> c4c237c > > This pulls in the following Native Client changes: > > 95163bf: (stichnot@chromium.org) Update revision for PNaCl > abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS > b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers > 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc > f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO > aebc3c4: (mcgrathr@chromium.org) Update chrome_rev > c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. > > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6ae1327a43c948f4666fef9e84fe351ab7c..c4c237c0567cbe1c7de664a4d81673c3403cf55b > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build > > Committed: https://crrev.com/97c9eecf2e7a5857d6dc6ddb22eb27251f9eefc4 > Cr-Commit-Position: refs/heads/master@{#369294} TBR=mcgrathr@chromium.org,mseaborn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/aadf6d08977ed7e23b42ec21ce58311061aeef18 Cr-Commit-Position: refs/heads/master@{#369382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
vasilii
Created Revert of NaCl: Update revision in DEPS, 26c7e6a -> c4c237c
4 years, 11 months ago (2016-01-14 09:45:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586683003/1
4 years, 11 months ago (2016-01-14 09:45:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 09:46:54 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aadf6d08977ed7e23b42ec21ce58311061aeef18 Cr-Commit-Position: refs/heads/master@{#369382}
4 years, 11 months ago (2016-01-14 09:48:39 UTC) #6
Nico
erikchen: maybe due to your cl? On Thu, Jan 14, 2016 at 4:48 AM, commit-bot@chromium.org ...
4 years, 11 months ago (2016-01-14 12:33:23 UTC) #7
Nico
erikchen: maybe due to your cl? On Thu, Jan 14, 2016 at 4:48 AM, commit-bot@chromium.org ...
4 years, 11 months ago (2016-01-14 12:33:24 UTC) #8
Mark Seaborn
On 14 January 2016 at 04:33, Nico Weber <thakis@chromium.org> wrote: > erikchen: maybe due to ...
4 years, 11 months ago (2016-01-14 16:55:47 UTC) #9
Mark Seaborn
On 14 January 2016 at 04:33, Nico Weber <thakis@chromium.org> wrote: > erikchen: maybe due to ...
4 years, 11 months ago (2016-01-14 16:55:48 UTC) #10
Nico
Is a new nacl roll in the works? On Thu, Jan 14, 2016 at 11:55 ...
4 years, 11 months ago (2016-01-19 23:47:08 UTC) #11
Nico
Is a new nacl roll in the works? On Thu, Jan 14, 2016 at 11:55 ...
4 years, 11 months ago (2016-01-19 23:47:10 UTC) #12
Mark Seaborn
On 19 January 2016 at 15:47, Nico Weber <thakis@chromium.org> wrote: > Is a new nacl ...
4 years, 11 months ago (2016-01-19 23:57:43 UTC) #13
Mark Seaborn
4 years, 11 months ago (2016-01-19 23:57:43 UTC) #14
Message was sent while issue was closed.
On 19 January 2016 at 15:47, Nico Weber <thakis@chromium.org> wrote:

> Is a new nacl roll in the works?
>

Yes, I'll revert the change that's blocking the roll.

Mark


> On Thu, Jan 14, 2016 at 11:55 AM, Mark Seaborn <mseaborn@chromium.org>
> wrote:
>
>> On 14 January 2016 at 04:33, Nico Weber <thakis@chromium.org> wrote:
>>
>>> erikchen: maybe due to your cl?
>>>
>>
>> No, I think this was caused by
>> https://codereview.chromium.org/1572753002/, which apparently broke the
>> PNaCl/nacl-clang tools on OS X 10.6 by adding a dependency on the system's
>> libc++.  It would have been rolled in by the change "95163bf: (
>> stichnot@chromium.org) Update revision for PNaCl".
>>
>> Mark
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698