 Chromium Code Reviews
 Chromium Code Reviews Issue 1586653002:
  ui: Fix TouchEvent PointerDetails creation from NativeEvent  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1586653002:
  ui: Fix TouchEvent PointerDetails creation from NativeEvent  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: ui/events/win/events_win.cc | 
| diff --git a/ui/events/win/events_win.cc b/ui/events/win/events_win.cc | 
| index 20c6e61b6aea65ad033e43785421ff38f37b9417..e45733122de27e0aaa31a1dd7a90a38e6c5ecce3 100644 | 
| --- a/ui/events/win/events_win.cc | 
| +++ b/ui/events/win/events_win.cc | 
| @@ -322,24 +322,20 @@ int GetTouchId(const base::NativeEvent& xev) { | 
| return 0; | 
| } | 
| -float GetTouchRadiusX(const base::NativeEvent& native_event) { | 
| - NOTIMPLEMENTED(); | 
| - return 1.0; | 
| -} | 
| - | 
| -float GetTouchRadiusY(const base::NativeEvent& native_event) { | 
| - NOTIMPLEMENTED(); | 
| - return 1.0; | 
| -} | 
| - | 
| float GetTouchAngle(const base::NativeEvent& native_event) { | 
| NOTIMPLEMENTED(); | 
| return 0.0; | 
| } | 
| -float GetTouchForce(const base::NativeEvent& native_event) { | 
| +PointerDetails GetTouchPointerDetailsFromNative( | 
| + const base::NativeEvent& native_event) { | 
| NOTIMPLEMENTED(); | 
| - return 0.0; | 
| + return PointerDetails(EventPointerType::POINTER_TYPE_TOUCH, | 
| + /* radius_x */ 1.0, | 
| + /* radius_y */ 1.0, | 
| + /* force */ 0.f, | 
| + /* tilt_x */ 0.f, | 
| + /* tilt_y */ 0.f); | 
| 
sadrul
2016/01/15 17:24:12
Oh wow. Do we not set these fields on Windows at a
 
robert.bradford
2016/01/18 15:25:22
On Windows blink populates from the NativeEvent di
 | 
| } | 
| bool GetScrollOffsets(const base::NativeEvent& native_event, |