Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: ui/events/cocoa/events_mac.mm

Issue 1586653002: ui: Fix TouchEvent PointerDetails creation from NativeEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use 1.0 consitently for default touch radius (change on Mac and stub.) Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/events/event.cc » ('j') | ui/events/event_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/cocoa/events_mac.mm
diff --git a/ui/events/cocoa/events_mac.mm b/ui/events/cocoa/events_mac.mm
index 79beaf39305d486f2dfccf5c7a3c34b8f8927a89..7b1eb3144e6102962826f47c3cff2fce770cab8c 100644
--- a/ui/events/cocoa/events_mac.mm
+++ b/ui/events/cocoa/events_mac.mm
@@ -178,24 +178,20 @@ int GetTouchId(const base::NativeEvent& native_event) {
return 0;
}
-float GetTouchRadiusX(const base::NativeEvent& native_event) {
- NOTIMPLEMENTED();
- return 0.f;
-}
-
-float GetTouchRadiusY(const base::NativeEvent& native_event) {
- NOTIMPLEMENTED();
- return 0.f;
-}
-
float GetTouchAngle(const base::NativeEvent& native_event) {
NOTIMPLEMENTED();
return 0.f;
}
-float GetTouchForce(const base::NativeEvent& native_event) {
+PointerDetails GetTouchPointerDetailsFromNative(
+ const base::NativeEvent& native_event) {
NOTIMPLEMENTED();
- return 0.f;
+ return PointerDetails(EventPointerType::POINTER_TYPE_TOUCH,
sadrul 2016/01/15 17:24:11 POINTER_TYPE_UNKNOWN?
robert.bradford 2016/01/18 15:25:22 Done.
+ /* radius_x */ 1.0,
+ /* radius_y */ 1.0,
+ /* force */ 0.f,
+ /* tilt_x */ 0.f,
+ /* tilt_y */ 0.f);
}
bool GetScrollOffsets(const base::NativeEvent& native_event,
« no previous file with comments | « no previous file | ui/events/event.cc » ('j') | ui/events/event_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698