ui: Fix TouchEvent PointerDetails creation from NativeEvent

ui/events/x/events_x.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event_constants.h"
 
 #include <stddef.h>
 #include <string.h>
 #include <X11/extensions/XInput.h>
 #include <X11/extensions/XInput2.h>
@@ skipping 94 matching lines @@
  private:
   friend struct base::DefaultSingletonTraits<XModifierStateWatcher>;
 
   XModifierStateWatcher() : state_(0) { }
 
   unsigned int state_;
 
   DISALLOW_COPY_AND_ASSIGN(XModifierStateWatcher);
 };
 
+double GetTouchParamFromXEvent(XEvent* xev,
+                               ui::DeviceDataManagerX11::DataType val,
+                               double default_value) {
+  ui::DeviceDataManagerX11::GetInstance()->GetEventData(*xev, val,
+                                                        &default_value);
+  return default_value;
+}
+
+void ScaleTouchRadius(XEvent* xev, double* radius) {
+  DCHECK_EQ(GenericEvent, xev->type);
+  XIDeviceEvent* xiev = static_cast<XIDeviceEvent*>(xev->xcookie.data);
+  ui::DeviceDataManagerX11::GetInstance()->ApplyTouchRadiusScale(xiev->sourceid,
+                                                                 radius);
+}
+
+float GetTouchRadiusX(const base::NativeEvent& native_event) {
+  double radius =
+      GetTouchParamFromXEvent(native_event,
+                              ui::DeviceDataManagerX11::DT_TOUCH_MAJOR, 0.0) /
+      2.0;
+  ScaleTouchRadius(native_event, &radius);
+  return radius;
+}
+
+float GetTouchRadiusY(const base::NativeEvent& native_event) {
+  double radius =
+      GetTouchParamFromXEvent(native_event,
+                              ui::DeviceDataManagerX11::DT_TOUCH_MINOR, 0.0) /
+      2.0;
+  ScaleTouchRadius(native_event, &radius);
+  return radius;
+}
+
+float GetTouchForce(const base::NativeEvent& native_event) {
+  double force = 0.0;
+  force = GetTouchParamFromXEvent(
+      native_event, ui::DeviceDataManagerX11::DT_TOUCH_PRESSURE, 0.0);
+  unsigned int deviceid =
+      static_cast<XIDeviceEvent*>(native_event->xcookie.data)->sourceid;
+  // Force is normalized to fall into [0, 1]
+  if (!ui::DeviceDataManagerX11::GetInstance()->NormalizeData(
+          deviceid, ui::DeviceDataManagerX11::DT_TOUCH_PRESSURE, &force))
+    force = 0.0;
+  return force;
+}
+
 // Detects if a touch event is a driver-generated 'special event'.
 // A 'special event' is a touch event with maximum radius and pressure at
 // location (0, 0).
 // This needs to be done in a cleaner way: http://crbug.com/169256
 bool TouchEventIsGeneratedHack(const base::NativeEvent& native_event) {
   XIDeviceEvent* event =
       static_cast<XIDeviceEvent*>(native_event->xcookie.data);
   CHECK(event->evtype == XI_TouchBegin ||
         event->evtype == XI_TouchUpdate ||
         event->evtype == XI_TouchEnd);
 
   // Force is normalized to [0, 1].
-  if (ui::GetTouchForce(native_event) < 1.0f)
+  if (GetTouchForce(native_event) < 1.0f)
     return false;
 
   if (ui::EventLocationFromNative(native_event) != gfx::Point())
     return false;
 
   // Radius is in pixels, and the valuator is the diameter in pixels.
-  double radius = ui::GetTouchRadiusX(native_event), min, max;
+  double radius = GetTouchRadiusX(native_event), min, max;
   unsigned int deviceid =
       static_cast<XIDeviceEvent*>(native_event->xcookie.data)->sourceid;
   if (!ui::DeviceDataManagerX11::GetInstance()->GetDataRange(
       deviceid, ui::DeviceDataManagerX11::DT_TOUCH_MAJOR, &min, &max)) {
     return false;
   }
 
   return radius * 2 == max;
 }
 
@@ skipping 127 matching lines @@
       if (!(event->flags & XIPointerEmulated) &&
           GetButtonMaskForX2Event(event))
         return ui::ET_TOUCH_MOVED;
       return ui::ET_UNKNOWN;
     default:
       NOTREACHED();
   }
   return ui::ET_UNKNOWN;
 }
 
-double GetTouchParamFromXEvent(XEvent* xev,
-                              ui::DeviceDataManagerX11::DataType val,
-                              double default_value) {
-  ui::DeviceDataManagerX11::GetInstance()->GetEventData(
-      *xev, val, &default_value);
-  return default_value;
-}
-
-void ScaleTouchRadius(XEvent* xev, double* radius) {
-  DCHECK_EQ(GenericEvent, xev->type);
-  XIDeviceEvent* xiev = static_cast<XIDeviceEvent*>(xev->xcookie.data);
-  ui::DeviceDataManagerX11::GetInstance()->ApplyTouchRadiusScale(
-      xiev->sourceid, radius);
-}
-
 unsigned int UpdateX11EventFlags(int ui_flags, unsigned int old_x_flags) {
   static struct {
     int ui;
     int x;
   } flags[] = {
     {ui::EF_SHIFT_DOWN, ShiftMask},
     {ui::EF_CAPS_LOCK_ON, LockMask},
     {ui::EF_CONTROL_DOWN, ControlMask},
     {ui::EF_ALT_DOWN, Mod1Mask},
     {ui::EF_NUM_LOCK_ON, Mod2Mask},
@@ skipping 438 matching lines @@
   if (!manager->GetEventData(
       *xev, ui::DeviceDataManagerX11::DT_TOUCH_TRACKING_ID, &tracking_id)) {
     LOG(ERROR) << "Could not get the tracking ID for the event. Using 0.";
   } else {
     ui::TouchFactory* factory = ui::TouchFactory::GetInstance();
     slot = factory->GetSlotForTrackingID(tracking_id);
   }
   return slot;
 }
 
-float GetTouchRadiusX(const base::NativeEvent& native_event) {
-  double radius = GetTouchParamFromXEvent(native_event,
-      ui::DeviceDataManagerX11::DT_TOUCH_MAJOR, 0.0) / 2.0;
-  ScaleTouchRadius(native_event, &radius);
-  return radius;
-}
-
-float GetTouchRadiusY(const base::NativeEvent& native_event) {
-  double radius = GetTouchParamFromXEvent(native_event,
-      ui::DeviceDataManagerX11::DT_TOUCH_MINOR, 0.0) / 2.0;
-  ScaleTouchRadius(native_event, &radius);
-  return radius;
-}
 
 float GetTouchAngle(const base::NativeEvent& native_event) {
   return GetTouchParamFromXEvent(native_event,
       ui::DeviceDataManagerX11::DT_TOUCH_ORIENTATION, 0.0) / 2.0;
 }
 
-float GetTouchForce(const base::NativeEvent& native_event) {
-  double force = 0.0;
-  force = GetTouchParamFromXEvent(native_event,
-      ui::DeviceDataManagerX11::DT_TOUCH_PRESSURE, 0.0);
-  unsigned int deviceid =
-      static_cast<XIDeviceEvent*>(native_event->xcookie.data)->sourceid;
-  // Force is normalized to fall into [0, 1]
-  if (!ui::DeviceDataManagerX11::GetInstance()->NormalizeData(
-      deviceid, ui::DeviceDataManagerX11::DT_TOUCH_PRESSURE, &force))
-    force = 0.0;
-  return force;
+PointerDetails GetTouchPointerDetailsFromNative(
+    const base::NativeEvent& native_event) {
+  return PointerDetails(
+      EventPointerType::POINTER_TYPE_TOUCH, GetTouchRadiusX(native_event),
+      GetTouchRadiusY(native_event), GetTouchForce(native_event),
+      /* tilt_x */ 0.f,
+      /* tilt_y */ 0.f);
 }
 
 bool GetScrollOffsets(const base::NativeEvent& native_event,
                       float* x_offset,
                       float* y_offset,
                       float* x_offset_ordinal,
                       float* y_offset_ordinal,
                       int* finger_count) {
   if (DeviceDataManagerX11::GetInstance()->IsScrollEvent(native_event)) {
     // Temp values to prevent passing NULLs to DeviceDataManager.
@@ skipping 100 matching lines @@
       xievent->detail =
           UpdateX11EventButton(event->changed_button_flags(), xievent->detail);
       break;
     }
     default:
       break;
   }
 }
 
 }  // namespace ui