ui: Fix TouchEvent PointerDetails creation from NativeEvent

ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.

Committed: https://crrev.com/c584bbb7783fc305105ba3d5772d3bfac21153b4
Cr-Commit-Position: refs/heads/master@{#370110}

[robert.bradford, 2016-01-14 16:21:05]

Description was changed from

==========
ui: Refactor TouchEvent PointerDetails creation

BUG=575162
==========

to

==========
ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.
==========

[robert.bradford, 2016-01-14 16:42:07]

Description was changed from

==========
ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.
==========

to

==========
ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.
==========

[robert.bradford, 2016-01-14 16:45:27]

robert.bradford@intel.com changed reviewers:
+ mustaq@chromium.org, sadrul@chromium.org

[robert.bradford, 2016-01-14 16:45:27]

robert.bradford@intel.com changed required reviewers:
+ sadrul@chromium.org

[robert.bradford, 2016-01-14 16:45:27]

Hi sadrul@ this this the equivalent of spang@'s fix for NativeEvents on mouse. I
used this change as an opportunity to consolidate the native event platform
functions too.

mustaq@ you're here for FYI, but review always welcome.

[sadrul, 2016-01-15 17:24:12]

lgtm

https://codereview.chromium.org/1586653002/diff/20001/ui/events/cocoa/events_...
File ui/events/cocoa/events_mac.mm (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/cocoa/events_...
ui/events/cocoa/events_mac.mm:189: return
PointerDetails(EventPointerType::POINTER_TYPE_TOUCH,
POINTER_TYPE_UNKNOWN?

https://codereview.chromium.org/1586653002/diff/20001/ui/events/event_utils.h
File ui/events/event_utils.h (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/event_utils.h...
ui/events/event_utils.h:130: EVENTS_EXPORT float GetTouchAngle(const
base::NativeEvent& native_event);
We could perhaps get rid of this too?

https://codereview.chromium.org/1586653002/diff/20001/ui/events/events_stub.cc
File ui/events/events_stub.cc (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/events_stub.c...
ui/events/events_stub.cc:97: return
PointerDetails(EventPointerType::POINTER_TYPE_TOUCH,
_UNKNOWN.

Let's start with _UNKNOWN for stub impls (both here and for cocoa)

https://codereview.chromium.org/1586653002/diff/20001/ui/events/win/events_wi...
File ui/events/win/events_win.cc (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/win/events_wi...
ui/events/win/events_win.cc:338: /* tilt_y */ 0.f);
Oh wow. Do we not set these fields on Windows at all?

[robert.bradford, 2016-01-18 15:25:22]

Thanks sadrul@ some responses below!

https://codereview.chromium.org/1586653002/diff/20001/ui/events/cocoa/events_...
File ui/events/cocoa/events_mac.mm (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/cocoa/events_...
ui/events/cocoa/events_mac.mm:189: return
PointerDetails(EventPointerType::POINTER_TYPE_TOUCH,
On 2016/01/15 17:24:11, sadrul wrote:
> POINTER_TYPE_UNKNOWN?

Done.

https://codereview.chromium.org/1586653002/diff/20001/ui/events/event_utils.h
File ui/events/event_utils.h (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/event_utils.h...
ui/events/event_utils.h:130: EVENTS_EXPORT float GetTouchAngle(const
base::NativeEvent& native_event);
On 2016/01/15 17:24:11, sadrul wrote:
> We could perhaps get rid of this too?

This isn't something that's currently captured in the PointerDetails struct.
I'll look into pulling it into that.

https://codereview.chromium.org/1586653002/diff/20001/ui/events/events_stub.cc
File ui/events/events_stub.cc (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/events_stub.c...
ui/events/events_stub.cc:97: return
PointerDetails(EventPointerType::POINTER_TYPE_TOUCH,
On 2016/01/15 17:24:12, sadrul wrote:
> _UNKNOWN.
> 
> Let's start with _UNKNOWN for stub impls (both here and for cocoa)

Done.

https://codereview.chromium.org/1586653002/diff/20001/ui/events/win/events_wi...
File ui/events/win/events_win.cc (right):

https://codereview.chromium.org/1586653002/diff/20001/ui/events/win/events_wi...
ui/events/win/events_win.cc:338: /* tilt_y */ 0.f);
On 2016/01/15 17:24:12, sadrul wrote:
> Oh wow. Do we not set these fields on Windows at all?

On Windows blink populates from the NativeEvent directly (although that might
differ between Metro mode or not):
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

[robert.bradford, 2016-01-19 14:14:28]

The CQ bit was checked by robert.bradford@intel.com

[robert.bradford, 2016-01-19 14:14:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1586653002/#ps60001
(title: "Rebase following X event refactor")

[commit-bot: I haz the power, 2016-01-19 14:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586653002/60001

[commit-bot: I haz the power, 2016-01-19 14:18:36]

Description was changed from

==========
ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.
==========

to

==========
ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.
==========

[commit-bot: I haz the power, 2016-01-19 14:18:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-19 14:19:52]

Description was changed from

==========
ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.
==========

to

==========
ui: Fix TouchEvent PointerDetails creation from NativeEvent

This change replaces the GetTouchRadiusX/GetTouchRadiusY/GetTouchForce platform
functions with a single GetTouchPointerDtailsFromNative function, which aligns
with the behaviour for MouseEvent.

The default implementation for this (used on ozone) will correctly preserve the
pointer type for the TouchEvent now.

This change also modifies the default radius values for Mac OS X and the stub
implementation to match the documented default of 1.0.

BUG=575162
TEST=events_unittest passed on all platforms, interactive testing of Pointer
Events of touch events on link.

Committed: https://crrev.com/c584bbb7783fc305105ba3d5772d3bfac21153b4
Cr-Commit-Position: refs/heads/master@{#370110}
==========

[commit-bot: I haz the power, 2016-01-19 14:19:53]

Patchset 4 (id:??) landed as
https://crrev.com/c584bbb7783fc305105ba3d5772d3bfac21153b4
Cr-Commit-Position: refs/heads/master@{#370110}