[WebSocket] Fix permessage-deflate handshake failure messages.

[WebSocket] Fix permessage-deflate handshake failure messages.

BUG=339373
R=ricea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252008

[Adam Rice, 2014-02-10 10:16:14]

https://codereview.chromium.org/158663003/diff/1/net/websockets/websocket_bas...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/158663003/diff/1/net/websockets/websocket_bas...
net/websockets/websocket_basic_handshake_stream.cc:245: "Error in
permessage-deflate: "
There are enough of these that it is probably worth having a little function to
add the prefix and return false, so you can just do

return FormatDeflateError(failure_message, "Received duplicate
permessage-deflate extension parameter " + name);

or similar.

[yhirano, 2014-02-10 12:17:32]

https://codereview.chromium.org/158663003/diff/1/net/websockets/websocket_bas...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/158663003/diff/1/net/websockets/websocket_bas...
net/websockets/websocket_basic_handshake_stream.cc:245: "Error in
permessage-deflate: "
On 2014/02/10 10:16:14, Adam Rice wrote:
> There are enough of these that it is probably worth having a little function
to
> add the prefix and return false, so you can just do
> 
> return FormatDeflateError(failure_message, "Received duplicate
> permessage-deflate extension parameter " + name);
> 
> or similar.

Done.

[Adam Rice, 2014-02-10 12:31:24]

https://codereview.chromium.org/158663003/diff/50001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/158663003/diff/50001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:225: bool
DeflateError(std::string* message, const char* piece) {
Please use base::StringPiece for the second argument so that you don't need two
versions of the function.

Sorry to be fussy.

[yhirano, 2014-02-13 04:56:17]

https://codereview.chromium.org/158663003/diff/50001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/158663003/diff/50001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:225: bool
DeflateError(std::string* message, const char* piece) {
On 2014/02/10 12:31:24, Adam Rice wrote:
> Please use base::StringPiece for the second argument so that you don't need
two
> versions of the function.
> 
> Sorry to be fussy.

Done.

[Adam Rice, 2014-02-13 05:33:04]

lgtm

[yhirano, 2014-02-19 04:02:21]

+tyoshino for OWNER review.

[tyoshino (SeeGerritForStatus), 2014-02-19 05:44:44]

lgtm

[yhirano, 2014-02-19 05:45:21]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-02-19 05:45:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/158663003/100001

[commit-bot: I haz the power, 2014-02-19 08:36:38]

Change committed as 252008