Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1586623002: Eliminate use of SVG1DOM counter by final split (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
Ilya Sherman, fs
CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate use of SVG1DOM counter by final split BUG=415074 Committed: https://crrev.com/03241f904f6a9337173beff0f6aae75058071a51 Cr-Commit-Position: refs/heads/master@{#369380}

Patch Set 1 #

Patch Set 2 : Remove SVG1DOM from UseCounter.h #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -47 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGClipPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCursorElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGForeignObjectElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMarkerElement.idl View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
davve
Last CL on the SVG1DOM split. PTAL. +isherman for histograms.
4 years, 11 months ago (2016-01-13 11:36:15 UTC) #2
fs
lgtm
4 years, 11 months ago (2016-01-13 11:55:03 UTC) #3
Ilya Sherman
histograms.xml lgtm
4 years, 11 months ago (2016-01-13 19:27:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586623002/40001
4 years, 11 months ago (2016-01-14 07:46:37 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 09:34:30 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 09:35:25 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03241f904f6a9337173beff0f6aae75058071a51
Cr-Commit-Position: refs/heads/master@{#369380}

Powered by Google App Engine
This is Rietveld 408576698