Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 1586613003: UMA histogram of user action on multi-account password update bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewers comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index 37e7f241e0ed59337199a1ea827df85cd0fb69c5..a0fd231d4e28d147c6069d73951bbbf1511620a0 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -110,6 +110,19 @@ enum UpdatePasswordSubmissionEvent {
NO_UPDATE_SUBMISSION
};
+enum MultiAccountUpdateBubbleUserAction {
+ DEFAULT_ACCOUNT_MATCHED_BY_PASSWORD_USER_CHANGED,
+ DEFAULT_ACCOUNT_MATCHED_BY_PASSWORD_USER_NOT_CHANGED,
+ DEFAULT_ACCOUNT_MATCHED_BY_PASSWORD_USER_REJECTED_UPDATE,
+ DEFAULT_ACCOUNT_PREFERRED_USER_CHANGED,
+ DEFAULT_ACCOUNT_PREFERRED_USER_NOT_CHANGED,
+ DEFAULT_ACCOUNT_PREFERRED_USER_REJECTED_UPDATE,
+ DEFAULT_ACCOUNT_FIRST_USER_CHANGED,
+ DEFAULT_ACCOUNT_FIRST_USER_NOT_CHANGED,
+ DEFAULT_ACCOUNT_FIRST_USER_REJECTED_UPDATE,
+ MULTI_ACCOUNT_UPDATE_BUBBLE_USER_ACTION_COUNT
+};
+
// We monitor the performance of the save password heuristic for a handful of
// domains. For privacy reasons we are not reporting UMA signals by domain, but
// by a domain group. A domain group can contain multiple domains, and a domain
@@ -174,6 +187,11 @@ void LogPasswordGenerationAvailableSubmissionEvent(
// Log submission events related to password update.
void LogUpdatePasswordSubmissionEvent(UpdatePasswordSubmissionEvent event);
+// Log a user action on showing an update password bubble with multiple
+// accounts.
+void LogMultiAccountUpdateBubbleUserAction(
+ MultiAccountUpdateBubbleUserAction action);
+
} // namespace metrics_util
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698