Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8757)

Unified Diff: chrome/browser/ui/views/passwords/credentials_selection_view.h

Issue 1586613003: UMA histogram of user action on multi-account password update bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/credentials_selection_view.h
diff --git a/chrome/browser/ui/views/passwords/credentials_selection_view.h b/chrome/browser/ui/views/passwords/credentials_selection_view.h
index 4c5d4bfe08c167e4542273e29999f56657ce0691..c6e3542eccafc0da491d3594fbb26f20ad6c3141 100644
--- a/chrome/browser/ui/views/passwords/credentials_selection_view.h
+++ b/chrome/browser/ui/views/passwords/credentials_selection_view.h
@@ -23,12 +23,19 @@ class CredentialsSelectionView : public views::View {
ManagePasswordsBubbleModel* manage_passwords_bubble_model,
const std::vector<const autofill::PasswordForm*>& password_forms,
const base::string16& best_matched_username);
+ ~CredentialsSelectionView() override;
const autofill::PasswordForm* GetSelectedCredentials();
private:
+ void ReportUserAction(bool was_update_rejected, int selected_index);
vasilii 2016/01/13 13:54:25 Better name ReportUserActionOnce
dvadym 2016/01/13 14:55:37 Done.
+
const std::vector<const autofill::PasswordForm*>& password_forms_;
views::Combobox* combobox_;
+ int default_index;
+ bool is_default_best_match;
+ bool is_default_preferred;
+ bool action_reported;
vasilii 2016/01/13 13:54:25 Add '_' to the end.
dvadym 2016/01/13 14:55:37 Done.
DISALLOW_COPY_AND_ASSIGN(CredentialsSelectionView);
};

Powered by Google App Engine
This is Rietveld 408576698