Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: Source/WebKit/chromium/src/WebBindings.cpp

Issue 15866003: Teach WebString about 8 bit strings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Better std::string pattern Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebBindings.cpp
diff --git a/Source/WebKit/chromium/src/WebBindings.cpp b/Source/WebKit/chromium/src/WebBindings.cpp
index 21a9031d6d0d07e305a2f4ddc4da7dabc7fa2ee9..cec9aa251107750abe03008ade328dc03d8f85f9 100644
--- a/Source/WebKit/chromium/src/WebBindings.cpp
+++ b/Source/WebKit/chromium/src/WebBindings.cpp
@@ -290,9 +290,11 @@ static NPObject* makeIntArrayImpl(const WebVector<int>& data)
static NPObject* makeStringArrayImpl(const WebVector<WebString>& data)
{
v8::HandleScope handleScope;
+ v8::Isolate* isolate = v8::Isolate::GetCurrent();
+
v8::Handle<v8::Array> result = v8::Array::New(data.size());
for (size_t i = 0; i < data.size(); ++i)
- result->Set(i, data[i].data() ? v8::String::New(reinterpret_cast<const uint16_t*>((data[i].data())), data[i].length()) : v8::String::New(""));
+ result->Set(i, v8String(String(data[i]), isolate));
DOMWindow* window = toDOMWindow(v8::Context::GetCurrent());
return npCreateV8ScriptObject(0, result, window);

Powered by Google App Engine
This is Rietveld 408576698