Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1586563006: Add "#include <string.h>" (Closed)

Created:
4 years, 11 months ago by hashimoto
Modified:
4 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "#include <string.h>" http://crrev.com/369348 removed string.h from base/macros.h BUG=None TBR=satorux@chromium.org Committed: https://crrev.com/b73820f15d91fab1e1b07a9f6bcc0a44ce8e077b Cr-Commit-Position: refs/heads/master@{#369693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chromeos/binder/buffer_reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hashimoto
4 years, 11 months ago (2016-01-15 05:37:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586563006/1
4 years, 11 months ago (2016-01-15 05:37:17 UTC) #5
satorux1
lgtm
4 years, 11 months ago (2016-01-15 05:48:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 05:53:38 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 05:54:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b73820f15d91fab1e1b07a9f6bcc0a44ce8e077b
Cr-Commit-Position: refs/heads/master@{#369693}

Powered by Google App Engine
This is Rietveld 408576698