Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 158653002: Remove unused attribute document.TypeNotations (Closed)

Created:
6 years, 10 months ago by silverroots
Modified:
6 years, 10 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed Layout Test Cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1958 lines) Patch
D LayoutTests/dom/html/level1/core/hc_nodevalue08.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_nodevalue08.js View 1 1 chunk +0 lines, -134 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_nodevalue08-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_notationsremovenameditem1.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_notationsremovenameditem1.js View 1 1 chunk +0 lines, -133 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_notationsremovenameditem1-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_notationssetnameditem1.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_notationssetnameditem1.js View 1 1 chunk +0 lines, -144 lines 0 comments Download
D LayoutTests/dom/html/level1/core/hc_notationssetnameditem1-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/html/level2/core/hc_notationsremovenameditemns1.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/dom/html/level2/core/hc_notationsremovenameditemns1.js View 1 1 chunk +0 lines, -141 lines 0 comments Download
D LayoutTests/dom/html/level2/core/hc_notationsremovenameditemns1-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/html/level2/core/hc_notationssetnameditemns1.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/dom/html/level2/core/hc_notationssetnameditemns1.js View 1 1 chunk +0 lines, -143 lines 0 comments Download
D LayoutTests/dom/html/level2/core/hc_notationssetnameditemns1-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_nodevalue08.js View 1 1 chunk +0 lines, -134 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_nodevalue08.xhtml View 1 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_nodevalue08-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_notationsremovenameditem1.js View 1 1 chunk +0 lines, -133 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_notationsremovenameditem1.xhtml View 1 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_notationsremovenameditem1-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_notationssetnameditem1.js View 1 1 chunk +0 lines, -144 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_notationssetnameditem1.xhtml View 1 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/dom/xhtml/level1/core/hc_notationssetnameditem1-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/xhtml/level2/core/hc_notationsremovenameditemns1.js View 1 1 chunk +0 lines, -141 lines 0 comments Download
D LayoutTests/dom/xhtml/level2/core/hc_notationsremovenameditemns1.xhtml View 1 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/dom/xhtml/level2/core/hc_notationsremovenameditemns1-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/xhtml/level2/core/hc_notationssetnameditemns1.js View 1 1 chunk +0 lines, -143 lines 0 comments Download
D LayoutTests/dom/xhtml/level2/core/hc_notationssetnameditemns1.xhtml View 1 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/dom/xhtml/level2/core/hc_notationssetnameditemns1-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentType.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
silverroots
6 years, 10 months ago (2014-02-10 06:18:02 UTC) #1
silverroots
On 2014/02/10 06:18:02, silverroots wrote: Sorry forgot to add LayoutTests. Uploading new patch.
6 years, 10 months ago (2014-02-10 06:19:45 UTC) #2
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-10 18:37:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaustubh.a@samsung.com/158653002/60001
6 years, 10 months ago (2014-02-10 18:38:06 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 20:18:38 UTC) #5
Message was sent while issue was closed.
Change committed as 166857

Powered by Google App Engine
This is Rietveld 408576698