Adding an API to read module annotations in snapshot.gyp

snapshot/client/crashpad_annotations_win.h

 // Copyright 2016 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "handler/prune_crash_reports_thread.h"
+#ifndef CRASHPAD_SNAPSHOT_SNAPSHOT_CLIENT_CRASHPAD_ANNOTATIONS_WIN_H_

[scottmg, 2016/01/13 19:12:42]

There's an extra SNAPSHOT_ in the guard here.

[Patrick Monette, 2016/01/13 22:59:40]

Removed.

+#define CRASHPAD_SNAPSHOT_SNAPSHOT_CLIENT_CRASHPAD_ANNOTATIONS_WIN_H_
 
-#include <utility>
+#include <windows.h>
 
-#include "client/prune_crash_reports.h"
+#include <map>
 
 namespace crashpad {
 
-PruneCrashReportThread::PruneCrashReportThread(
-    CrashReportDatabase* database,
-    scoped_ptr<PruneCondition> condition)
-    : thread_(60 * 60 * 24, this),
-      condition_(std::move(condition)),
-      database_(database) {}
-
-PruneCrashReportThread::~PruneCrashReportThread() {}
-
-void PruneCrashReportThread::Start() {
-  thread_.Start(60 * 10);
-}
-
-void PruneCrashReportThread::Stop() {
-  thread_.Stop();
-}
-
-void PruneCrashReportThread::DoWork(const WorkerThread* thread) {
-  PruneCrashReportDatabase(database_, condition_.get());
-}
+// Reads the crashpad annotations associated to |module| inside |process| and

[scottmg, 2016/01/13 19:12:42]

crashpad -> Crashpad. Or maybe instead, since we know they're Crashpad
annotations when we're in Crashpad, it should be module annotations. The file
name and function name should be changed to match.

[scottmg, 2016/01/13 19:12:42]

These need to be Doxygen-ized in Crashpad. Comments start with //!, followed by
a \brief summary. Instead of |arg|, use \a arg, and add \param[in] and
\param[out] documentation for the arguments.

[Patrick Monette, 2016/01/13 22:59:40]

Done.

[Patrick Monette, 2016/01/13 22:59:40]

Done.

+// inserts them into |annotations|. |process| requires PROCESS_QUERY_INFORMATION
+// and PROCESS_VM_READ access. On error, returns false and does not modify
+// |annotations|.
+bool ReadCrashpadAnnotations(HANDLE process,
+                             HMODULE module,

[scottmg, 2016/01/13 19:12:42]

Is it going to be tricky for a user to provide HMODULE?

[Patrick Monette, 2016/01/13 22:59:40]

Good question. Currently I was thinking about enumerating all modules and
chosing the one with basename chrome.exe. Does that seem sufficient?

+                             std::map<std::string, std::string>* annotations);

[scottmg, 2016/01/13 19:12:42]

#include <string>

[Patrick Monette, 2016/01/13 22:59:40]

Done.

 
 }  // namespace crashpad
+
+#endif  // CRASHPAD_SNAPSHOT_SNAPSHOT_CLIENT_CRASHPAD_ANNOTATIONS_WIN_H_