Adding an API to read module annotations in snapshot.gyp

snapshot/client/crashpad_annotations_win.cc

+// Copyright 2016 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "snapshot/client/crashpad_annotations_win.h"
+
+#include <psapi.h>
+
+#include "snapshot/win/process_reader_win.h"
+#include "snapshot/win/pe_image_reader.h"
+#include "snapshot/win/pe_image_annotations_reader.h"
+
+namespace crashpad {
+
+bool ReadCrashpadAnnotations(HANDLE process,
+                             HMODULE module,
+                             std::map<std::string, std::string>* annotations) {
+  ProcessReaderWin process_reader;
+  if (!process_reader.Initialize(process, ProcessSuspensionState::kRunning))

[scottmg, 2016/01/13 19:12:42]

Would it be a good idea to suspend the process before reading here? See
ScopedProcessSuspend.

[Patrick Monette, 2016/01/13 22:59:39]

If you think it's a good idea, I don't see any objections.

+    return false;
+
+  MODULEINFO module_info = {};

[scottmg, 2016/01/13 19:12:42]

I don't think this needs to be initialized, as it's documented as [out] for
GetModuleInformation().

[Patrick Monette, 2016/01/13 22:59:39]

Done.

+  if (!::GetModuleInformation(

[scottmg, 2016/01/13 19:12:42]

No :: prefix in Crashpad unless it's necessary to disambiguate.

[scottmg, 2016/01/13 19:12:42]

I believe this needs the GET_FUNCTION_REQUIRED dance that
snapshot/win/pe_image_reader_test.cc does in order to work correctly on
pre-Win7.

[Patrick Monette, 2016/01/13 22:59:39]

Done.

[Patrick Monette, 2016/01/13 22:59:40]

Done.

+          process, module, &module_info, sizeof(module_info)))
+    return false;

[scottmg, 2016/01/13 19:12:42]

PLOG(ERROR) << "GetModuleInformation" here.

[Patrick Monette, 2016/01/13 22:59:39]

Done.

+
+  PEImageReader image_reader;
+  if (!image_reader.Initialize(
+          &process_reader,
+          reinterpret_cast<crashpad::WinVMAddress>(module_info.lpBaseOfDll),
+          module_info.SizeOfImage,
+          ""))
+    return false;
+
+  PEImageAnnotationsReader annotations_reader(
+      &process_reader, &image_reader, L"");
+
+  *annotations = annotations_reader.SimpleMap();
+  return true;
+}
+
+}  // namespace crashpad