Add a PPAPI browser tests for an issue of NaCl crash

Add a PPAPI browser tests for an issue of NaCl crash.

These tests verifie that the crash of NaCl module introduced by r200088 does
not occur when PPB_FileIO_Private::RequestOSFileHandle is called with
PPB_FileIO opened with PP_FILEOPENFLAG_EXCLUSIVE. 

BUG=243241, 241726
TEST=
browser_tests --gtest_filter="PPAPI*Test.FileIO" passes
Revert r200088
browser_tests --gtest_filter="PPAPI*Test.FileIO" crashes

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203124

[mazda, 2013-05-23 23:52:24]

Hello Mark,

Could you review this CL?
This is a follow-up CL of https://codereview.chromium.org/15274002/.
I separated the CL because the crash fix was urgent.

This test causes NaCl module crash like the following if
https://codereview.chromium.org/15274002/ is not applied.
[26189:26189:0523/160952:246943824383:INFO:CONSOLE(0)] "NativeClient: [26275,201
770752:16:09:52.126434] NaClHostDescPosixMake(50,0xc2): Take failed, error
-22a", source: http://127.0.0.1:58787/files/ppapi_ppb_file_io.html (0)

Thanks,

[Mark Seaborn, 2013-05-28 15:04:03]

I'm not a good reviewer for this because I'm not very familiar with how PPAPI
features are tested -- adding dmichael instead.

Should this test go in ppapi/tests instead?  e.g. See test_file_*.cc there. 
chrome/test/nacl is for tests that are NaCl-specific whereas ppapi/tests is for
PPAPI-only tests, which seems a better fit.

https://codereview.chromium.org/15864005/diff/2001/chrome/test/data/nacl/ppap...
File chrome/test/data/nacl/ppapi/ppb_file_io/ppapi_ppb_file_io.cc (right):

https://codereview.chromium.org/15864005/diff/2001/chrome/test/data/nacl/ppap...
chrome/test/data/nacl/ppapi/ppb_file_io/ppapi_ppb_file_io.cc:34: FileResources*
resources = static_cast<FileResources*>(data);
Should this also test that the file handle the callback receives is usable?

[dmichael (off chromium), 2013-05-28 15:23:05]

Mark's right, we should just test this in ppapi/tests/

It looks like we already have a test for this:
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/tests/test_f...

And it is run for NaCl:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/ppapi/...

If there's something that test doesn't have that you are adding, please add it
there.

[mazda, 2013-05-30 05:10:26]

Thank you for the pointer. I moved the test to ppapi/tests.
Please take another look.

[dmichael (off chromium), 2013-05-30 05:17:15]

lgtm, thanks!

https://codereview.chromium.org/15864005/diff/15001/ppapi/tests/test_file_io.cc
File ppapi/tests/test_file_io.cc (right):

https://codereview.chromium.org/15864005/diff/15001/ppapi/tests/test_file_io....
ppapi/tests/test_file_io.cc:1114: // This is a regression test for that issue.
Please reference the bug here.

[mazda, 2013-05-30 05:35:18]

Thank you for the prompt review.

https://codereview.chromium.org/15864005/diff/15001/ppapi/tests/test_file_io.cc
File ppapi/tests/test_file_io.cc (right):

https://codereview.chromium.org/15864005/diff/15001/ppapi/tests/test_file_io....
ppapi/tests/test_file_io.cc:1114: // This is a regression test for that issue.
On 2013/05/30 05:17:15, dmichael wrote:
> Please reference the bug here.

Done.

[commit-bot: I haz the power, 2013-05-30 05:35:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/15864005/22001

[commit-bot: I haz the power, 2013-05-30 12:19:35]

Change committed as 203124