Issue 15864004: Move create() methods from StylePropertySet to MutableStylePropertySet.

Issue 15864004: Move create() methods from StylePropertySet to MutableStylePropertySet. (Closed)

Created:
7 years, 7 months ago by darktears

Modified:
7 years, 7 months ago

Reviewers:
apavlov, commit-bot: I haz the power, esprehn, eseidel, darktears

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, Rik, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, f(malita), Stephen Chennney, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move create() methods from StylePropertySet to MutableStylePropertySet. Move the two create() methods that create MutableStylePropertySets from StylePropertySet to MutableStylePropertySet, and make them actually return MutableStylePropertySets. Switch to using {Pass,}RefPtr<MutableStylePropertySet> where appropriate to keep things building. This is a backport from WebKit r148395. Patch by Andreas Kling and reviewed by Antti Koivisto. R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151009

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -50 lines)			Patch
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/DOMWindowCSS.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/FontLoader.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/StylePropertySet.h	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	Source/core/css/StylePropertySet.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/WebKitCSSMatrix.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/Attr.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/StyledElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/ApplyStyleCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/EditingStyle.cpp	View	8 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/core/editing/Editor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/EditorCommand.cpp	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLTableElement.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/page/DragController.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGElementRareData.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGFontFaceElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGStyledElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download