chrome/browser/resources/md_history/history_item.html - Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history_item.html

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Address reviewer comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/history_card_manager.js ('K') | « chrome/browser/resources/md_history/history_card_manager.js ('k') | chrome/browser/resources/md_history/history_item.js » ('j') | chrome/browser/resources/md_history/history_item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history_item.html

diff --git a/chrome/browser/resources/md_history/history_item.html b/chrome/browser/resources/md_history/history_item.html

index 13408fa0225fca31c7806823bb1cd58bc4986c37..53b5a1260c5ba8c886205215b20951e23713f443 100644

--- a/chrome/browser/resources/md_history/history_item.html

+++ b/chrome/browser/resources/md_history/history_item.html

@@ -82,7 +82,7 @@

</style>

<paper-checkbox id="checkbox" on-tap="checkboxSelected"

- checked="{{selected}}">

+ checked="{{selected}}" disabled="{{selectionAllowed_()}}">

tsergeant 2016/01/25 01:43:14 I'm not convinced about this pattern...but I don't

hsampson 2016/01/25 04:15:42 Acknowledged.

</paper-checkbox>

<span id="time">{{timeAccessed}}</span>