chrome/browser/resources/md_history/history-card.html - Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history-card.html

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Add TODO and remove console.logs. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/history.js ('K') | « chrome/browser/resources/md_history/history.js ('k') | chrome/browser/resources/md_history/history-card-manager.js » ('j') | chrome/browser/resources/md_history/history-card-manager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history-card.html

diff --git a/chrome/browser/resources/md_history/history-card.html b/chrome/browser/resources/md_history/history-card.html

index cf495955b83bf024d5d4081e540bf230316e20d5..3da4959f396bc218ee62af71bad13110cae6eb08 100644

--- a/chrome/browser/resources/md_history/history-card.html

+++ b/chrome/browser/resources/md_history/history-card.html

@@ -56,10 +56,9 @@

website-domain="{{historyItem.domain}}"

website-url="{{historyItem.url}}"

starred="{{historyItem.starred}}"

- selected="{{historyItem.selected}}"

- timestamp="{{historyItem.time}}">

+ selected="{{historyItem.selected}}">

</history-item>

- <template is="dom-if" if="{{needsTimeGap_(index, historyItem)}}">

+ <template is="dom-if" if="{{needsTimeGap_(index, historyItems.length)}}">

tsergeant 2016/01/18 02:33:52 You should change the definition of needsTimeGap_

hsampson 2016/01/19 23:41:39 Done.

</template>