chrome/browser/resources/md_history/history_toolbar.html - Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_history/history_toolbar.html

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Address reviewer comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_history/history_item.js ('K') | « chrome/browser/resources/md_history/history_item.js ('k') | chrome/browser/resources/md_history/history_toolbar.js » ('j') | chrome/browser/ui/webui/md_history_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

5 <link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_searc h_field.html">	5 <link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_searc h_field.html">

6	6

7 <dom-module id="history-toolbar">	7 <dom-module id="history-toolbar">

8 <template>	8 <template>

9	9

10 <style>	10 <style>

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 <div id="items">	59 <div id="items">

60 <paper-icon-button icon="clear" id="cancel-icon-button"	60 <paper-icon-button icon="clear" id="cancel-icon-button"

61 on-tap="clearSelection">	61 on-tap="clearSelection">

62 </paper-icon-button>	62 </paper-icon-button>

63 <!-- TODO: change "selected" and number to an i18n (or equivalent)	63 <!-- TODO: change "selected" and number to an i18n (or equivalent)

64 string -->	64 string -->

65 <div id="number-selected">{{count}} selected</div>	65 <div id="number-selected">{{count}} selected</div>

66 <paper-button id="cancel-button" on-tap="clearSelection">	66 <paper-button id="cancel-button" on-tap="clearSelection">

67 CANCEL	67 CANCEL

68 </paper-button>	68 </paper-button>

69 <paper-button id="delete-button">DELETE</paper-button>	69 <template is="dom-if" if="{{deletingAllowed_()}}">

	70 <paper-button id="delete-button" on-tap="deleteSelection">
	tsergeant 2016/01/25 01:43:15 deleteSelection -> onDeleteTap_ deleteSelection -> onDeleteTap_ hsampson 2016/01/25 04:15:42 Done. Show quoted text On 2016/01/25 01:43:15, tsergeant wrote: > deleteSelection -> onDeleteTap_ Done.
	71 DELETE

	72 </paper-button>

	73 </template>

70 </div>	74 </div>

71 </template>	75 </template>

72	76

73 </template>	77 </template>

74 <script src="chrome://history/history_toolbar.js"></script>	78 <script src="chrome://history/history_toolbar.js"></script>

75 </dom-module>	79 </dom-module>

OLD	NEW