Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/resources/md_history/history_item.js

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded
Patch Set: Address reviewer comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 Polymer({ 5 Polymer({
6 is: 'history-item', 6 is: 'history-item',
7 properties: { 7 properties: {
8 timeAccessed: { 8 timeAccessed: {
9 type: String, 9 type: String,
10 value: '' 10 value: ''
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 openMenu: function(e) { 82 openMenu: function(e) {
83 var position = this.$['menu-button'].getBoundingClientRect(); 83 var position = this.$['menu-button'].getBoundingClientRect();
84 84
85 this.fire('toggle-menu', { 85 this.fire('toggle-menu', {
86 x: position.left, 86 x: position.left,
87 y: position.top, 87 y: position.top,
88 accessTime: this.timestamp 88 accessTime: this.timestamp
89 }); 89 });
90 // Stops the 'tap' event from closing the menu when it opens. 90 // Stops the 'tap' event from closing the menu when it opens.
91 e.stopPropagation(); 91 e.stopPropagation();
92 },
93
94 selectionAllowed_: function() {
tsergeant 2016/01/25 01:43:15 The truthiness of your variable/function names fli
hsampson 2016/01/25 04:15:42 Done.
95 return !loadTimeData.getBoolean('allowDeletingHistory');
92 } 96 }
93 }); 97 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698