MD History: Delete button in the toolbar allows deletion of multiple history-items.

chrome/browser/resources/md_history/history_card_manager.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-card-manager',
 
   properties: {
     // An array of objects sorted in reverse chronological order.
     // Each object has a date and the history items belonging to that date.
@@ skipping 82 matching lines @@
     }
     if (currentDate != undefined)
       this.appendHistoryData_(currentDate, historyItems);
 
     this.lastVisitedTime = historyItems[historyItems.length - 1].time;
   },
 
   /**
    * Cycle through each entry in historyDataByDay_ and set all items to be
    * unselected.
+   * @param {number} overallItemCount the number of items selected.

[calamity, 2016/01/21 00:11:08]

nit: Capitalize 'The' since it's the start of the description. (repeat
elsewhere)

[hsampson, 2016/01/21 05:34:47]

Done.

    */
   unselectAllItems: function(overallItemCount) {
     var historyCardData = this.historyDataByDay_;
 
     for (var i = 0; i < historyCardData.length; i++) {
       var items = historyCardData[i].historyItems;
       for (var j = 0; j < items.length; j++) {
         if (items[j].selected) {
           this.set('historyDataByDay_.' + i + '.historyItems.' + j +
               '.selected', false);
           overallItemCount--;
           if (overallItemCount == 0)
-            break;
+            return;
         }
       }
     }
   },
 
   /**
+   * Remove all selected items from the overall array so that they are also
+   * removed from view. Make sure that the card length and positioning is
+   * updated accordingly.
+   * @param {number} overallItemCount the number of items selected.
+   */
+  removeDeletedHistory: function(overallItemCount) {
+    var itemDeletedFromCard = false;
+
+    for (var i = 0; i < this.historyDataByDay_.length; i++) {
+      var items = this.historyDataByDay_[i].historyItems;
+
+      for (var j = items.length - 1; j > -1; j--) {

[calamity, 2016/01/21 00:11:08]

j >= 0 tends to be the usual way to do this.

[hsampson, 2016/01/21 05:34:46]

Done.

+        if (items[j].selected) {
+          this.splice('historyDataByDay_.' + i + '.historyItems', j, 1);
+          itemDeletedFromCard = true;
+          overallItemCount--;
+          if (overallItemCount == 0) {
+            this.removeEmptyCards_();
+            // If the last card has been removed don't try to update its size.
+            if (this.historyDataByDay_.length > i) {
+              this.$['infinite-list'].updateSizeForItem(i);
+            }
+            return;
+          }
+        }
+      }
+      if (itemDeletedFromCard)
+        this.$['infinite-list'].updateSizeForItem(i);
+      itemDeletedFromCard = false;

[calamity, 2016/01/21 00:11:08]

Instead of doing this, just move the declaration of itemDeletedFromCard inside
the first for loop.

[hsampson, 2016/01/21 05:34:46]

Done.

+    }
+  },
+
+  /**
+   * If a given day has had all the history it contains removed, remove this
+   * day from the array.
+   * @private
+   */
+  removeEmptyCards_: function() {
+    var historyCards = this.historyDataByDay_;
+    for (var i = historyCards.length - 1; i > -1; i--) {
+      if (historyCards[i].historyItems.length == 0) {
+        this.splice('historyDataByDay_', i, 1);
+      }
+    }
+  },
+
+  /**
    * Adds the given items into historyDataByDay_. Adds items to the last
    * existing day if the date matches, creates a new element otherwise.
    * @param {string} date The date of the history items.
    * @param {Array<HistoryEntry>} historyItems The list of history items for the
    * current date.
    * @private
    */
   appendHistoryData_: function(date, historyItems) {
     var lastDay = this.historyDataByDay_.length - 1;
     if (lastDay > 0 && date == this.historyDataByDay_[lastDay].date) {
       this.set('historyDataByDay_.' + lastDay + '.historyItems',
           this.historyDataByDay_[lastDay].historyItems.concat(historyItems));
     } else {
       this.push('historyDataByDay_', {
         date: date,
         historyItems: historyItems
       });
     }
   },
 
   /**
+   * Based on which items are selected, collect an array of the info required
+   * for chrome.send('removeHistory', ...).
+   * @param {number} count The number of items that are selected.
+   * @return {array} toBeRemoved An array of objects which contain information
+   * on which history-items should be deleted.
+   */
+  getItemsToDelete: function(count) {

[calamity, 2016/01/21 00:11:08]

After a small chat with Tim, I think there's a possibility of improving the
processing.

So the code is often looping through the entirety of history data in order to
find selected things. My idea was to pass more information in the notification
so that we could have history-card-manager track all selected items and just
have enough information there to do what we need.

I think this change is moderately complex and you would need to account for
changing indexes when deleting items. It's a fun data flow/structure and code
design problem though.

tl;dr: it would be nice to have a history-card-manager.selectedItems array

It's up to you whether you want to do this now/later/ever. Feel free to grab me
for a chat if you are having the big confuse.

[hsampson, 2016/01/21 05:34:46]

Once all of the big cls are uploaded I will create a separate cl to deal with
this.

[tsergeant, 2016/01/25 01:43:14]

Chris and I have ~even more~ ideas about how to do this. Let's chat about it
when CLs start clearing up.

+    var toBeRemoved = [];
+    for (var i = 0; i < this.historyDataByDay_.length; i++) {
+      var items = this.historyDataByDay_[i].historyItems;
+      for (j = 0; j < items.length; j++) {
+        if (items[j].selected) {
+
+          toBeRemoved.push({
+            url: items[j].url,
+            timestamps: items[j].allTimestamps
+          });
+
+          count--;
+          if (count == 0)
+            break;

[calamity, 2016/01/21 00:11:08]

Change this to return toBeRemoved;

[hsampson, 2016/01/21 05:34:46]

Done.

+        }
+      }
+    }
+    return toBeRemoved;
+  },
+
+  /**
    * Called when the card manager is scrolled.
    * @private
    */
   scrollHandler_: function() {
     // Closes overflow menu on scroll.
     this.closeMenu();
 
     this.loadMoreIfAtEnd_();
   },
 
   /**
    * Requests the next list of results when the scrollbar is near the bottom
    * of the window.
    */
   loadMoreIfAtEnd_: function() {
     var scrollOffset = 10;
     var scrollElem = this.$['infinite-list'];
 
     if (scrollElem.scrollHeight <=
         scrollElem.scrollTop + scrollElem.clientHeight + scrollOffset) {
       chrome.send('queryHistory',
           ['', 0, 0, this.lastVisitedTime, RESULTS_PER_PAGE]);
     }
   }
 });