MD History: Delete button in the toolbar allows deletion of multiple history-items.

chrome/browser/ui/webui/md_history_ui.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/md_history_ui.h"
 
+#include "base/prefs/pref_service.h"
 #include "build/build_config.h"
+#include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/browsing_history_handler.h"
 #include "chrome/browser/ui/webui/metrics_handler.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/search/search.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "grit/browser_resources.h"
 #include "grit/components_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 
 #if !defined(OS_ANDROID)
 #include "chrome/browser/ui/webui/foreign_session_handler.h"
 #include "chrome/browser/ui/webui/history_login_handler.h"
 #endif
 
 namespace {
 
-content::WebUIDataSource* CreateMdHistoryUIHTMLSource() {
+content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
+  PrefService* prefs = profile->GetPrefs();
+
   content::WebUIDataSource* source =
       content::WebUIDataSource::Create(chrome::kChromeUIHistoryHost);
 
   // Localized strings (alphabetical order).
   source->AddLocalizedString("moreFromSite", IDS_HISTORY_MORE_FROM_SITE);
   source->AddLocalizedString("removeFromHistory", IDS_HISTORY_REMOVE_PAGE);
   source->AddLocalizedString("title", IDS_HISTORY_TITLE);
   source->AddLocalizedString("clearSearch", IDS_MD_HISTORY_CLEAR_SEARCH);
   source->AddLocalizedString("search", IDS_MD_HISTORY_SEARCH);
 
   source->AddResourcePath("history-card.html",IDR_MD_HISTORY_HISTORY_CARD_HTML);
   source->AddResourcePath("history-card.js", IDR_MD_HISTORY_HISTORY_CARD_JS);
   source->AddResourcePath("history-card-manager.html",
                           IDR_MD_HISTORY_HISTORY_CARD_MANAGER_HTML);
   source->AddResourcePath("history-card-manager.js",
                           IDR_MD_HISTORY_HISTORY_CARD_MANAGER_JS);
   source->AddResourcePath("history-item.html",
                           IDR_MD_HISTORY_HISTORY_ITEM_HTML);
   source->AddResourcePath("history-item.js", IDR_MD_HISTORY_HISTORY_ITEM_JS);
   source->AddResourcePath("history-toolbar.html",
                           IDR_MD_HISTORY_HISTORY_TOOLBAR_HTML);
   source->AddResourcePath("history-toolbar.js",
                           IDR_MD_HISTORY_HISTORY_TOOLBAR_JS);
   source->AddResourcePath("history.js", IDR_MD_HISTORY_HISTORY_JS);
 
   source->SetDefaultResource(IDR_MD_HISTORY_HISTORY_HTML);
   source->SetJsonPath("strings.js");
 
+  bool allow_deleting_history =
+      prefs->GetBoolean(prefs::kAllowDeletingBrowserHistory);
+  source->AddBoolean("allowDeletingHistory", allow_deleting_history);

[tsergeant, 2016/01/18 02:33:52]

Hmmmmmmmmmm, we'd better make sure there's a test for this.

(This is the sort of feature that's really easy to forget about, so it's useful
to have machines remember it rather than relying on humans)

There's an example for how to test this in the old UI:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...

Ping me when you want to work on this test and I can explain what needs to be
done.

[tsergeant, 2016/01/18 02:35:59]

(to be extra-clear, I'd like to see a test for this, but I'd also generally like
tests for the normal deletion functions).

[hsampson, 2016/01/19 23:41:39]

Done.

+
   return source;
 }
 
 }  // namespace
 
 MdHistoryUI::MdHistoryUI(content::WebUI* web_ui) : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new BrowsingHistoryHandler());
   web_ui->AddMessageHandler(new MetricsHandler());
 
   // On mobile we deal with foreign sessions differently.
 #if !defined(OS_ANDROID)
   if (search::IsInstantExtendedAPIEnabled()) {
     web_ui->AddMessageHandler(new browser_sync::ForeignSessionHandler());
     web_ui->AddMessageHandler(new HistoryLoginHandler());
   }
 #endif
 
   Profile* profile = Profile::FromWebUI(web_ui);
-  content::WebUIDataSource::Add(profile, CreateMdHistoryUIHTMLSource());
+  content::WebUIDataSource::Add(profile, CreateMdHistoryUIHTMLSource(profile));
 }
 
 MdHistoryUI::~MdHistoryUI() {}
 
 base::RefCountedMemory* MdHistoryUI::GetFaviconResourceBytes(
     ui::ScaleFactor scale_factor) {
   return ResourceBundle::GetSharedInstance().LoadDataResourceBytesForScale(
       IDR_HISTORY_FAVICON, scale_factor);
 }