MD History: Delete button in the toolbar allows deletion of multiple history-items.

chrome/browser/resources/md_history/history_card_manager.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-card-manager',
 
   properties: {
     // An array of objects sorted in reverse chronological order.
     // Each object has a date and the history items belonging to that date.
@@ skipping 86 matching lines @@
 
     if (currentDate)
       this.appendHistoryData_(currentDate, historyItems);
 
     this.lastVisitedTime = historyItems[historyItems.length - 1].time;
   },
 
   /**
    * Cycle through each entry in historyDataByDay_ and set all items to be
    * unselected.
+   * @param {number} overallItemCount The number of items selected.
    */
   unselectAllItems: function(overallItemCount) {
     var historyCardData = this.historyDataByDay_;
 
     for (var i = 0; i < historyCardData.length; i++) {
       var items = historyCardData[i].historyItems;
       for (var j = 0; j < items.length; j++) {
         if (items[j].selected) {
           this.set('historyDataByDay_.' + i + '.historyItems.' + j +
               '.selected', false);
           overallItemCount--;
           if (overallItemCount == 0)
-            break;
+            return;
         }
       }
     }
   },
 
   /**
+   * Remove all selected items from the overall array so that they are also
+   * removed from view. Make sure that the card length and positioning is
+   * updated accordingly.
+   * @param {number} overallItemCount The number of items selected.
+   */
+  removeDeletedHistory: function(overallItemCount) {
+    for (var i = 0; i < this.historyDataByDay_.length; i++) {
+      var items = this.historyDataByDay_[i].historyItems;
+      var itemDeletedFromCard = false;
+
+      for (var j = items.length - 1; j >= 0; j--) {
+        if (items[j].selected) {

[calamity, 2016/02/02 05:34:58]

nit: Invert and use continue.

[hsampson, 2016/02/02 22:59:53]

Done.

+          this.splice('historyDataByDay_.' + i + '.historyItems', j, 1);
+          itemDeletedFromCard = true;
+          overallItemCount--;
+          if (overallItemCount == 0) {
+            this.removeEmptyCards_();
+            // If the last card has been removed don't try to update its size.
+            if (this.historyDataByDay_.length > i)

[calamity, 2016/02/02 05:34:58]

nit: Flip this around. Seeing a greater than comparison is making my head spin.

[hsampson, 2016/02/02 22:59:53]

Done.

+              this.$['infinite-list'].updateSizeForItem(i);
+            return;
+          }
+        }
+      }
+      if (itemDeletedFromCard)
+        this.$['infinite-list'].updateSizeForItem(i);
+    }
+  },
+
+  /**
+   * If a given day has had all the history it contains removed, remove this

[tsergeant, 2016/02/02 03:36:51]

Nit: Reword this comment.

The word 'given' implies that there's a parameter for removing a specific day.

(Although maybe don't worry too much, since history-card is due to be killed
anyway)

[hsampson, 2016/02/02 22:59:53]

Done.

+   * day from the array.
+   * @private
+   */
+  removeEmptyCards_: function() {
+    var historyCards = this.historyDataByDay_;
+    for (var i = historyCards.length - 1; i >= 0; i--) {
+      if (historyCards[i].historyItems.length == 0) {
+        this.splice('historyDataByDay_', i, 1);
+      }
+    }
+  },
+
+  /**
    * Adds the given items into historyDataByDay_. Adds items to the last
    * existing day if the date matches, creates a new element otherwise.
    * @param {string} date The date of the history items.
    * @param {!Array<!HistoryEntry>} historyItems The list of history items for
    * the current date.
    * @private
    */
   appendHistoryData_: function(date, historyItems) {
     var lastDay = this.historyDataByDay_.length - 1;
     if (lastDay > 0 && date == this.historyDataByDay_[lastDay].date) {
       this.set('historyDataByDay_.' + lastDay + '.historyItems',
           this.historyDataByDay_[lastDay].historyItems.concat(historyItems));
     } else {
       this.push('historyDataByDay_', {
         date: date,
         historyItems: historyItems
       });
     }
   },
 
   /**
+   * Based on which items are selected, collect an array of the info required
+   * for chrome.send('removeHistory', ...).
+   * @param {number} count The number of items that are selected.
+   * @return {Array<HistoryEntry>} toBeRemoved An array of objects which contain
+   * information on which history-items should be deleted.
+   */
+  getItemsToDelete: function(count) {

[calamity, 2016/02/02 05:34:58]

nit: getSelectedItems?

[hsampson, 2016/02/02 22:59:53]

Done.

+    var toBeRemoved = [];
+    for (var i = 0; i < this.historyDataByDay_.length; i++) {
+      var items = this.historyDataByDay_[i].historyItems;
+      for (var j = 0; j < items.length; j++) {
+        if (items[j].selected) {
+
+          toBeRemoved.push({
+            url: items[j].url,
+            timestamps: items[j].allTimestamps
+          });
+
+          count--;
+          if (count == 0)
+            return toBeRemoved;
+        }
+      }
+    }
+    return toBeRemoved;
+  },
+
+  /**
    * Called when the card manager is scrolled.
    * @private
    */
   scrollHandler_: function() {
     // Close overflow menu on scroll.
     this.closeMenu();
 
     // Requests the next list of results when the scrollbar is near the bottom
     // of the window.
     var scrollOffset = 10;
     var scrollElem = this.$['infinite-list'];
 
     if (scrollElem.scrollHeight <=
         scrollElem.scrollTop + scrollElem.clientHeight + scrollOffset) {
       chrome.send('queryHistory',
           ['', 0, 0, this.lastVisitedTime, RESULTS_PER_PAGE]);
     }
   }
 });