Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1586343003: cc: Add some tracing below LayerTreeHost::PushProperties. (Closed)

Created:
4 years, 11 months ago by danakj
Modified:
4 years, 11 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, Bernhard Bauer, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add some tracing below LayerTreeHost::PushProperties. Traces showed this taking 500ms which is ridiculous, so add some traces below it to try narrow this down a bit. R=enne BUG=577619 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a3089f057b2cc2d7a19717e000ddeded2000971 Cr-Commit-Position: refs/heads/master@{#369904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -20 lines) Patch
M cc/layers/layer.cc View 2 chunks +22 lines, -19 lines 0 comments Download
M cc/layers/nine_patch_layer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/surface_layer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/texture_layer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/ui_resource_layer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
danakj
4 years, 11 months ago (2016-01-15 22:39:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586343003/1
4 years, 11 months ago (2016-01-15 22:40:01 UTC) #4
enne (OOO)
lgtm
4 years, 11 months ago (2016-01-15 23:06:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586343003/1
4 years, 11 months ago (2016-01-15 23:08:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-16 01:20:20 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 01:21:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a3089f057b2cc2d7a19717e000ddeded2000971
Cr-Commit-Position: refs/heads/master@{#369904}

Powered by Google App Engine
This is Rietveld 408576698