Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1586253002: Add PossibleBreakpoints source reporting. (Closed)

Created:
4 years, 11 months ago by turnidge
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add PossibleBreakpoints source reporting. This allows tools developers to discover which token positions correspond to possible breakpoints in the code. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/539ac23fb402db64c771e07c6f31d0970bf12f25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -5 lines) Patch
M runtime/observatory/tests/service/get_source_report_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/source_report.h View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/source_report.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M runtime/vm/source_report_test.cc View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 11 months ago (2016-01-14 19:07:54 UTC) #2
rmacnak
lgtm
4 years, 11 months ago (2016-01-14 22:59:20 UTC) #3
turnidge
4 years, 11 months ago (2016-01-15 17:02:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
539ac23fb402db64c771e07c6f31d0970bf12f25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698