fpdfsdk/src/javascript/JS_Value.h - Issue 1586203006: Bugs in CJS_PublicMethods::ParseNumber()

Side by Side Diff: fpdfsdk/src/javascript/JS_Value.h

Issue 1586203006: Bugs in CJS_PublicMethods::ParseNumber() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Remove entirely, pass "NaN" as NaN. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef FPDFSDK_SRC_JAVASCRIPT_JS_VALUE_H_	7 #ifndef FPDFSDK_SRC_JAVASCRIPT_JS_VALUE_H_

8 #define FPDFSDK_SRC_JAVASCRIPT_JS_VALUE_H_	8 #define FPDFSDK_SRC_JAVASCRIPT_JS_VALUE_H_

9	9

10 #include "core/include/fxcrt/fx_basic.h"	10 #include "core/include/fxcrt/fx_basic.h"

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 bool ToBool() const;	55 bool ToBool() const;

56 double ToDouble() const;	56 double ToDouble() const;

57 float ToFloat() const;	57 float ToFloat() const;

58 CJS_Object* ToCJSObject() const;	58 CJS_Object* ToCJSObject() const;

59 CFX_WideString ToCFXWideString() const;	59 CFX_WideString ToCFXWideString() const;

60 CFX_ByteString ToCFXByteString() const;	60 CFX_ByteString ToCFXByteString() const;

61 v8::Local<v8::Object> ToV8Object() const;	61 v8::Local<v8::Object> ToV8Object() const;

62 v8::Local<v8::Array> ToV8Array() const;	62 v8::Local<v8::Array> ToV8Array() const;

63 v8::Local<v8::Value> ToV8Value() const;	63 v8::Local<v8::Value> ToV8Value() const;

64	64

	65 // Replace the current \|m_pValue\| with a v8::Number if possible

	66 // to make one from the current \|m_pValue\|, updating \|m_eType\|

	67 // as appropriate to indicate the result.

	68 void MaybeCoerceToNumber();
	jochen (gone - plz use gerrit) 2016/01/19 17:16:25 is it ok if the number has values like +infinity o is it ok if the number has values like +infinity or -0? Tom Sepez 2016/01/19 22:19:16 Probably. Remember, there isn't really a spec for Show quoted text On 2016/01/19 17:16:25, jochen wrote: > is it ok if the number has values like +infinity or -0? Probably. Remember, there isn't really a spec for this.
	69

65 void operator=(int iValue);	70 void operator=(int iValue);

66 void operator=(bool bValue);	71 void operator=(bool bValue);

67 void operator=(double);	72 void operator=(double);

68 void operator=(float);	73 void operator=(float);

69 void operator=(CJS_Object*);	74 void operator=(CJS_Object*);

70 void operator=(CJS_Document*);	75 void operator=(CJS_Document*);

71 void operator=(v8::Local<v8::Object>);	76 void operator=(v8::Local<v8::Object>);

72 void operator=(CJS_Array&);	77 void operator=(CJS_Array&);

73 void operator=(CJS_Date&);	78 void operator=(CJS_Date&);

74 void operator=(const FX_WCHAR* pWstr);	79 void operator=(const FX_WCHAR* pWstr);

(...skipping 127 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
202 int JS_GetMinFromTime(double dt);	207 int JS_GetMinFromTime(double dt);

203 int JS_GetSecFromTime(double dt);	208 int JS_GetSecFromTime(double dt);

204 double JS_DateParse(const wchar_t* string);	209 double JS_DateParse(const wchar_t* string);

205 double JS_MakeDay(int nYear, int nMonth, int nDay);	210 double JS_MakeDay(int nYear, int nMonth, int nDay);

206 double JS_MakeTime(int nHour, int nMin, int nSec, int nMs);	211 double JS_MakeTime(int nHour, int nMin, int nSec, int nMs);

207 double JS_MakeDate(double day, double time);	212 double JS_MakeDate(double day, double time);

208 bool JS_PortIsNan(double d);	213 bool JS_PortIsNan(double d);

209 double JS_LocalTime(double d);	214 double JS_LocalTime(double d);

210	215

211 #endif // FPDFSDK_SRC_JAVASCRIPT_JS_VALUE_H_	216 #endif // FPDFSDK_SRC_JAVASCRIPT_JS_VALUE_H_

OLD	NEW

« no previous file with comments | « fpdfsdk/src/javascript/Field.cpp ('k') | fpdfsdk/src/javascript/JS_Value.cpp » ('j') | fpdfsdk/src/javascript/PublicMethods.cpp » ('J')