Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1586203003: [proxy] Reload the initial map after prototype lookup on constructable (Closed)

Created:
4 years, 11 months ago by Camillo Bruni
Modified:
4 years, 11 months ago
Reviewers:
neis, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxy] Reload the initial map after prototype lookup on constructable Proxy. If a constructable Proxy changes the target's prototype during the prototype lookup the target's initial map stays uninitialized half-way during object construction. LOG=n BUG=chromium:578039 Committed: https://crrev.com/ec30425a779066d7a0750dbe6e81ffa494a2ced7 Cr-Commit-Position: refs/heads/master@{#33359}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 1

Patch Set 3 : year++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/objects.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-578039-Proxy_construct_prototype_change.js View 1 2 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Camillo Bruni
PTAL
4 years, 11 months ago (2016-01-15 13:28:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586203003/20001
4 years, 11 months ago (2016-01-15 13:57:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 14:23:30 UTC) #6
neis
lgtm but let Jakob have a look too
4 years, 11 months ago (2016-01-18 08:20:28 UTC) #7
Jakob Kummerow
lgtm https://codereview.chromium.org/1586203003/diff/20001/test/mjsunit/regress/regress-crbug-578039-Proxy_construct_prototype_change.js File test/mjsunit/regress/regress-crbug-578039-Proxy_construct_prototype_change.js (right): https://codereview.chromium.org/1586203003/diff/20001/test/mjsunit/regress/regress-crbug-578039-Proxy_construct_prototype_change.js#newcode1 test/mjsunit/regress/regress-crbug-578039-Proxy_construct_prototype_change.js:1: // Copyright 2015 the V8 project authors. All ...
4 years, 11 months ago (2016-01-18 10:23:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586203003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586203003/40001
4 years, 11 months ago (2016-01-18 12:19:21 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-18 12:48:42 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 12:49:37 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ec30425a779066d7a0750dbe6e81ffa494a2ced7
Cr-Commit-Position: refs/heads/master@{#33359}

Powered by Google App Engine
This is Rietveld 408576698