Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 15862004: Remove custom code for MessageEvent.ports getter (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, lgombos
Visibility:
Public.

Description

Remove custom code for MessageEvent.ports getter Use MessagePort[] instead of Array type for MessageEvent.ports attribute and remove custom code for the getter. Since the array is not nullable on JS side MessageEvent::ports() method now returns a Vector instead of a Vector* so that the bindings generator doesn't need to special case it. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151089

Patch Set 1 #

Patch Set 2 : Rebase patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -26 lines) Patch
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 3 chunks +27 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 2 chunks +4 lines, -20 lines 0 comments Download
M Source/core/dom/MessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-23 12:11:02 UTC) #1
do-not-use
On 2013/05/23 12:11:02, Christophe Dumez wrote: Sadly, bindings test results were not rebaselined so not ...
7 years, 7 months ago (2013-05-23 12:11:44 UTC) #2
haraken
LGTM. Great patch!
7 years, 7 months ago (2013-05-23 12:21:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15862004/1
7 years, 7 months ago (2013-05-23 12:23:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9577
7 years, 7 months ago (2013-05-23 13:22:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15862004/1
7 years, 7 months ago (2013-05-23 15:16:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9629
7 years, 7 months ago (2013-05-23 16:29:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15862004/1
7 years, 7 months ago (2013-05-24 06:28:57 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/bindings/tests/results/V8Float64Array.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-24 06:29:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15862004/25001
7 years, 7 months ago (2013-05-24 08:09:50 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9933
7 years, 7 months ago (2013-05-24 09:32:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15862004/25001
7 years, 7 months ago (2013-05-24 10:05:13 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9988
7 years, 7 months ago (2013-05-24 11:33:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15862004/25001
7 years, 7 months ago (2013-05-24 12:31:22 UTC) #14
do-not-use
7 years, 7 months ago (2013-05-24 13:40:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 manually as r151089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698