Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1586153004: PPC: [Interpreter] Add ForInPrepare runtime function which returns a ObjectTriple. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Add ForInPrepare runtime function which returns a ObjectTriple. Port 84f8a506e204b1e70df5b9a8036cc97170e661fd Original commit message: Adds a ForInPrepare Runtime function which returns a triple of cache_type, cache_array and cache_length. This requires adding support to CEntryStub to call runtime functions which return a ObjectTriple - a struct containing three Object* pointers. Also did some cleanup of the x64 CEntryStub to avoid replicated code. Replaces the interpreter's use of the ad-hock InterpreterForInPrepare Runtime function with ForInPrepare in preparation for fixing deopt in BytecodeGraphBuilder for ForIn (which will be done in a followup CL). R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/b2c246e0a95d377de4c1ba20b8e67ed6c97300e6 Cr-Commit-Position: refs/heads/master@{#33342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -45 lines) Patch
M src/ppc/assembler-ppc.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +12 lines, -16 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 5 chunks +41 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-15 17:57:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586153004/1
4 years, 11 months ago (2016-01-15 18:15:39 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 18:31:30 UTC) #5
john.yan
lgtm
4 years, 11 months ago (2016-01-15 19:01:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586153004/1
4 years, 11 months ago (2016-01-15 19:03:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 19:05:40 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 19:06:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2c246e0a95d377de4c1ba20b8e67ed6c97300e6
Cr-Commit-Position: refs/heads/master@{#33342}

Powered by Google App Engine
This is Rietveld 408576698