Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1586143003: Enable crash symbols unit test for Mac OSX. (Closed)

Created:
4 years, 11 months ago by David Yen
Modified:
4 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable crash symbols unit test for Mac OSX. R=nednguyen@google.com BUG=563716 Committed: https://crrev.com/7dfa2f79c2fda175f1202cac8d5a51d1e64a2171 Cr-Commit-Position: refs/heads/master@{#370745}

Patch Set 1 #

Patch Set 2 : Added filesystem test #

Patch Set 3 : Try to use fcntl to get the binary file. #

Patch Set 4 : Only import fcntl when needed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools/perf/core/stacktrace_unittest.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
David Yen
Placeholder CL for enabling crash symbols, I'll log into the trybot as it's being tried ...
4 years, 11 months ago (2016-01-14 19:21:39 UTC) #1
David Yen
It looks like I finally got this working, PTAL.
4 years, 11 months ago (2016-01-21 02:39:17 UTC) #2
nednguyen
lgtm
4 years, 11 months ago (2016-01-21 02:46:54 UTC) #3
nednguyen
avi@, can you also review this?
4 years, 11 months ago (2016-01-21 02:48:11 UTC) #5
Avi (use Gerrit)
If you do that right after, you're almost guaranteed to get the same results. LGTM; ...
4 years, 11 months ago (2016-01-21 15:07:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586143003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586143003/40001
4 years, 11 months ago (2016-01-21 16:17:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/157244)
4 years, 11 months ago (2016-01-21 17:27:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586143003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586143003/60001
4 years, 11 months ago (2016-01-21 17:49:59 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-21 19:25:07 UTC) #14
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/7dfa2f79c2fda175f1202cac8d5a51d1e64a2171 Cr-Commit-Position: refs/heads/master@{#370745}
4 years, 11 months ago (2016-01-21 19:26:56 UTC) #16
tsergeant
4 years, 11 months ago (2016-01-21 23:00:39 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1616743004/ by tsergeant@chromium.org.

The reason for reverting is: This patch appears to be causing failures in
telemetry_perf_unittests on Mac-10.9:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2....

Powered by Google App Engine
This is Rietveld 408576698