Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/browser/shell_integration.h

Issue 1586143002: Cleanup dual_mode handling in ShellIntegrationWin after Metro removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a1_cleanup_scottmg
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_ 5 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_
6 #define CHROME_BROWSER_SHELL_INTEGRATION_H_ 6 #define CHROME_BROWSER_SHELL_INTEGRATION_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 153
154 // Get the AppUserModelId for the App List, for the profile in |profile_path|. 154 // Get the AppUserModelId for the App List, for the profile in |profile_path|.
155 static base::string16 GetAppListAppModelIdForProfile( 155 static base::string16 GetAppListAppModelIdForProfile(
156 const base::FilePath& profile_path); 156 const base::FilePath& profile_path);
157 157
158 // Migrates existing chrome shortcuts by tagging them with correct app id. 158 // Migrates existing chrome shortcuts by tagging them with correct app id.
159 // see http://crbug.com/28104 159 // see http://crbug.com/28104
160 static void MigrateChromiumShortcuts(); 160 static void MigrateChromiumShortcuts();
161 161
162 // Migrates all shortcuts in |path| which point to |chrome_exe| such that they 162 // Migrates all shortcuts in |path| which point to |chrome_exe| such that they
163 // have the appropriate AppUserModelId. Also makes sure those shortcuts have 163 // have the appropriate AppUserModelId. Also clear the dual_mode property
grt (UTC plus 2) 2016/01/14 16:40:51 clear -> clears
gab 2016/01/14 17:09:29 Done.
164 // the dual_mode (ref. shell_util.h) property set if such is requested by 164 // from shortcuts that previously had as requested by |clear_dual_mode|.
grt (UTC plus 2) 2016/01/14 16:40:51 had as -> had it if
gab 2016/01/14 17:09:29 Done.
165 // |check_dual_mode|.
166 // Returns the number of shortcuts migrated. 165 // Returns the number of shortcuts migrated.
167 // This method should not be called prior to Windows 7. 166 // This method should not be called prior to Windows 7.
168 // This method is only public for the sake of tests and shouldn't be called 167 // This method is only public for the sake of tests and shouldn't be called
169 // externally otherwise. 168 // externally otherwise.
170 static int MigrateShortcutsInPathInternal(const base::FilePath& chrome_exe, 169 static int MigrateShortcutsInPathInternal(const base::FilePath& chrome_exe,
171 const base::FilePath& path, 170 const base::FilePath& path,
172 bool check_dual_mode); 171 bool clear_dual_mode);
173 172
174 // Returns the path to the Start Menu shortcut for the given Chrome. 173 // Returns the path to the Start Menu shortcut for the given Chrome.
175 static base::FilePath GetStartMenuShortcut(const base::FilePath& chrome_exe); 174 static base::FilePath GetStartMenuShortcut(const base::FilePath& chrome_exe);
176 #endif // defined(OS_WIN) 175 #endif // defined(OS_WIN)
177 176
178 #if !defined(OS_WIN) 177 #if !defined(OS_WIN)
179 // TODO(calamity): replace with 178 // TODO(calamity): replace with
180 // BrowserDistribution::GetStartMenuShortcutSubfolder() once 179 // BrowserDistribution::GetStartMenuShortcutSubfolder() once
181 // BrowserDistribution is cross-platform. 180 // BrowserDistribution is cross-platform.
182 // Gets the name of the Chrome Apps menu folder in which to place app 181 // Gets the name of the Chrome Apps menu folder in which to place app
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 // Returns the histogram prefix for DefaultProtocolClientWorker. 402 // Returns the histogram prefix for DefaultProtocolClientWorker.
404 const char* GetHistogramPrefix() override; 403 const char* GetHistogramPrefix() override;
405 404
406 std::string protocol_; 405 std::string protocol_;
407 406
408 DISALLOW_COPY_AND_ASSIGN(DefaultProtocolClientWorker); 407 DISALLOW_COPY_AND_ASSIGN(DefaultProtocolClientWorker);
409 }; 408 };
410 }; 409 };
411 410
412 #endif // CHROME_BROWSER_SHELL_INTEGRATION_H_ 411 #endif // CHROME_BROWSER_SHELL_INTEGRATION_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/shell_integration_win.cc » ('j') | chrome/browser/shell_integration_win_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698