Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1586133006: TBR. Turns out these tests still fail just for a different reason. (Closed)

Created:
4 years, 11 months ago by Jacob
Modified:
4 years, 11 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

TBR. Turns out these tests still fail just for a different reason. BUG= Committed: https://github.com/dart-lang/sdk/commit/c1d669131b158f3bd158f417f60593849618a352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/lib/analyzer/analyze_library.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
TBR
4 years, 11 months ago (2016-01-15 22:04:55 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as c1d669131b158f3bd158f417f60593849618a352 (presubmit successful).
4 years, 11 months ago (2016-01-15 22:05:33 UTC) #4
Alan Knight
4 years, 11 months ago (2016-01-15 22:05:35 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698