Add a switch in BUILD rules to control the generation of type info for mojom files.

Add a switch in BUILD rules to control the generation of type info for mojom files.

BUG= #596
R=rudominer@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/51f2690798f762364fdaff4ccc9c8747b73cd994

[azani, 2016-01-16 00:20:16]

azani@chromium.org changed reviewers:
+ rudominer@chromium.org

[azani, 2016-01-16 00:20:16]

ptal

[azani, 2016-01-16 00:23:48]

azani@chromium.org changed reviewers:
+ alexfandrianto@google.com

[azani, 2016-01-16 00:23:48]

ptal Alex

[alexfandrianto, 2016-01-16 00:31:31]

On 2016/01/16 00:20:16, azani wrote:
> ptal

I think this looks right in that it will only build the test mojoms with type
info. (Not sure if this will affect Dart since they have an extra generator
script ./mojo/dart/tools/bindings/generate.py)

Currently, I build Mojo with `mojo/tools/mojob.py gn && mojo/tools/mojob.py
build`.

I know I can tweak the mojom.gni file, but is there a way to build with a flag
that includes the mojom type info for all files? (I don't have any existing use
for it, AFAIK, but I could see a Vanadium server potentially needing to
interface with to one of the existing Mojo services. I want to check that we
aren't eliminating the possibility of doing this in the future.)

[azani, 2016-01-16 01:02:13]

On 2016/01/16 00:31:31, alexfandrianto wrote:
> On 2016/01/16 00:20:16, azani wrote:
> > ptal
> 
> I think this looks right in that it will only build the test mojoms with type
> info. (Not sure if this will affect Dart since they have an extra generator
> script ./mojo/dart/tools/bindings/generate.py)
> 
> Currently, I build Mojo with `mojo/tools/mojob.py gn && mojo/tools/mojob.py
> build`.
> 
> I know I can tweak the mojom.gni file, but is there a way to build with a flag
> that includes the mojom type info for all files? (I don't have any existing
use
> for it, AFAIK, but I could see a Vanadium server potentially needing to
> interface with to one of the existing Mojo services. I want to check that we
> aren't eliminating the possibility of doing this in the future.)

Yes, I figure generate.py might end up being a problem, but I don't have a deep
enough understanding of what is going on over there to make an informed
statement. If you run into trouble while making the Dart changes, let me know
and we'll figure something out.

As far as having the mojom type info available for all files, we could certainly
add a switch if that becomes necessary. Ultimately, this is just a change to our
BUILD configuration. If anyone wants to generate bindings with the generated
types, it's just a flag away.

[alexfandrianto, 2016-01-19 20:17:18]

On 2016/01/16 01:02:13, azani wrote:
> On 2016/01/16 00:31:31, alexfandrianto wrote:
> > On 2016/01/16 00:20:16, azani wrote:
> > > ptal
> > 
> > I think this looks right in that it will only build the test mojoms with
type
> > info. (Not sure if this will affect Dart since they have an extra generator
> > script ./mojo/dart/tools/bindings/generate.py)
> > 
> > Currently, I build Mojo with `mojo/tools/mojob.py gn && mojo/tools/mojob.py
> > build`.
> > 
> > I know I can tweak the mojom.gni file, but is there a way to build with a
flag
> > that includes the mojom type info for all files? (I don't have any existing
> use
> > for it, AFAIK, but I could see a Vanadium server potentially needing to
> > interface with to one of the existing Mojo services. I want to check that we
> > aren't eliminating the possibility of doing this in the future.)
> 
> Yes, I figure generate.py might end up being a problem, but I don't have a
deep
> enough understanding of what is going on over there to make an informed
> statement. If you run into trouble while making the Dart changes, let me know
> and we'll figure something out.
> 
> As far as having the mojom type info available for all files, we could
certainly
> add a switch if that becomes necessary. Ultimately, this is just a change to
our
> BUILD configuration. If anyone wants to generate bindings with the generated
> types, it's just a flag away.

That sounds good. FYI, I am good with this. I'll let Mitch give the approval.

[rudominer, 2016-01-19 23:39:10]

lgtm

[azani, 2016-01-20 00:00:50]

Description was changed from

==========
Add a switch in BUILD rules to control the generation of type info for mojom
files.

BUG= #596
==========

to

==========
Add a switch in BUILD rules to control the generation of type info for mojom
files.

BUG= #596
R=rudominer@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/51f2690798f762364fdaff4ccc9...
==========

[azani, 2016-01-20 00:00:53]

Committed patchset #3 (id:40001) manually as
51f2690798f762364fdaff4ccc9c8747b73cd994 (presubmit successful).