Issue 15861028: Implement MethodMirror.metadata.

Issue 15861028: Implement MethodMirror.metadata. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, ngeoffray, Johnni Winther, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement MethodMirror.metadata. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23529

Patch Set 2 : Merged with HEAD. #

Patch Set 3 : Address comments and deal with private members of BoundClosure #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -15 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/enqueue.dart	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2	4 chunks	+28 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1 2	2 chunks	+18 lines, -3 lines	2 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart	View	1 2	7 chunks	+27 lines, -6 lines	0 comments	Download
M	dart/tests/lib/mirrors/metadata_test.dart	View	1 2	3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/15861028/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right): https://codereview.chromium.org/15861028/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart#newcode491 dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:491: var metadataFunction = JS('', r'#.$metadata', _jsFunction); Could this ...

7 years, 6 months ago (2013-06-03 06:12:40 UTC) #2

ngeoffray

DBC https://codereview.chromium.org/15861028/diff/1/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart File dart/sdk/lib/_internal/compiler/implementation/enqueue.dart (right): https://codereview.chromium.org/15861028/diff/1/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart#newcode237 dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:237: // TODO(ahe): codegen should be smarter and only ...

7 years, 6 months ago (2013-06-03 06:51:55 UTC) #3

ahe

Committed patchset #3 manually as r23529 (presubmit successful).

7 years, 6 months ago (2013-06-03 09:12:43 UTC) #4

ahe

Thank you, Nicolas and Kasper. I made a few changes before submitting, and I'd appreciate ...

7 years, 6 months ago (2013-06-03 09:13:54 UTC) #5

kasperl

Looks even better! https://codereview.chromium.org/15861028/diff/8001/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart File dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right): https://codereview.chromium.org/15861028/diff/8001/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart#newcode961 dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:961: /// The reciever. i before e ...

7 years, 6 months ago (2013-06-03 10:23:21 UTC) #6

ahe

7 years, 6 months ago (2013-06-03 10:49:48 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/15861028/diff/8001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/15861028/diff/8001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:961: /// The
reciever.
On 2013/06/03 10:23:21, kasperl wrote:
> i before e except after c :-)

Done.

Expand Messages | Collapse Messages