base/platform_file_win.cc - Issue 15861011: Add an "append flag" to base::PlatformFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_file_win.cc

Issue 15861011: Add an "append flag" to base::PlatformFile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Style, reorder enum Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/platform_file_win.cc

diff --git a/base/platform_file_win.cc b/base/platform_file_win.cc

index cdc06bd1ca2bd192f150d89316d24f5348c5eb05..271491bd8c8c9de4f52775d1bbd6accbcd96bc47 100644

--- a/base/platform_file_win.cc

+++ b/base/platform_file_win.cc

@@ -51,9 +51,15 @@ PlatformFile CreatePlatformFileUnsafe(const FilePath& name,

return NULL;

}

- DWORD access = (flags & PLATFORM_FILE_READ) ? GENERIC_READ : 0;

+ DWORD access = 0;

if (flags & PLATFORM_FILE_WRITE)

- access |= GENERIC_WRITE;

+ access = GENERIC_WRITE;

+ if (flags & PLATFORM_FILE_APPEND) {

+ DCHECK(!access)

jar (doing other things) 2013/06/05 16:39:21 missing semicolon.

+ access = FILE_APPEND_DATA;

+ }

+ if (flags & PLATFORM_FILE_READ)

+ access |= GENERIC_READ;

if (flags & PLATFORM_FILE_WRITE_ATTRIBUTES)

access |= FILE_WRITE_ATTRIBUTES;

if (flags & PLATFORM_FILE_EXECUTE)

« base/platform_file_unittest.cc ('K') | « base/platform_file_unittest.cc ('k') | no next file » | no next file with comments »