Add an "append flag" to base::PlatformFile.

base/platform_file_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/platform_file.h"
 #include "base/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 17 matching lines @@
 } // namespace
 
 TEST(PlatformFile, CreatePlatformFile) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   FilePath file_path = temp_dir.path().AppendASCII("create_file_1");
 
   // Open a file that doesn't exist.
   base::PlatformFileError error_code = base::PLATFORM_FILE_OK;
   base::PlatformFile file = base::CreatePlatformFile(
-      file_path, base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ,
-      NULL, &error_code);
+      file_path,
+      base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ,
+      NULL,
+      &error_code);
   EXPECT_EQ(base::kInvalidPlatformFileValue, file);
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_NOT_FOUND, error_code);
 
   // Open or create a file.
   bool created = false;
   error_code = base::PLATFORM_FILE_OK;
   file = base::CreatePlatformFile(
-      file_path, base::PLATFORM_FILE_OPEN_ALWAYS | base::PLATFORM_FILE_READ,
-      &created, &error_code);
+      file_path,
+      base::PLATFORM_FILE_OPEN_ALWAYS | base::PLATFORM_FILE_READ,
+      &created,
+      &error_code);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
   EXPECT_TRUE(created);
   EXPECT_EQ(base::PLATFORM_FILE_OK, error_code);
   base::ClosePlatformFile(file);
 
   // Open an existing file.
   created = false;
   file = base::CreatePlatformFile(
-      file_path, base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ,
-      &created, &error_code);
+      file_path,
+      base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ,
+      &created,
+      &error_code);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
   EXPECT_FALSE(created);
   EXPECT_EQ(base::PLATFORM_FILE_OK, error_code);
   base::ClosePlatformFile(file);
 
   // Create a file that exists.
   file = base::CreatePlatformFile(
-      file_path, base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_READ,
-      &created, &error_code);
+      file_path,
+      base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_READ,
+      &created,
+      &error_code);
   EXPECT_EQ(base::kInvalidPlatformFileValue, file);
   EXPECT_FALSE(created);
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_EXISTS, error_code);
 
   // Create or overwrite a file.
   error_code = base::PLATFORM_FILE_OK;
   file = base::CreatePlatformFile(
-      file_path, base::PLATFORM_FILE_CREATE_ALWAYS | base::PLATFORM_FILE_READ,
-      &created, &error_code);
+      file_path,
+      base::PLATFORM_FILE_CREATE_ALWAYS | base::PLATFORM_FILE_READ,
+      &created,
+      &error_code);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
   EXPECT_TRUE(created);
   EXPECT_EQ(base::PLATFORM_FILE_OK, error_code);
   base::ClosePlatformFile(file);
 
   // Create a delete-on-close file.
   created = false;
   file_path = temp_dir.path().AppendASCII("create_file_2");
   file = base::CreatePlatformFile(
       file_path,
-      base::PLATFORM_FILE_OPEN_ALWAYS |
-      base::PLATFORM_FILE_DELETE_ON_CLOSE |
-      base::PLATFORM_FILE_READ,
+      base::PLATFORM_FILE_OPEN_ALWAYS | base::PLATFORM_FILE_DELETE_ON_CLOSE |
+          base::PLATFORM_FILE_READ,
       &created, &error_code);

[jar (doing other things), 2013/06/06 15:46:45]

nit: separate lines

   EXPECT_NE(base::kInvalidPlatformFileValue, file);
   EXPECT_TRUE(created);
   EXPECT_EQ(base::PLATFORM_FILE_OK, error_code);
 
   EXPECT_TRUE(base::ClosePlatformFile(file));
   EXPECT_FALSE(file_util::PathExists(file_path));
 }
 
 TEST(PlatformFile, DeleteOpenFile) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   FilePath file_path = temp_dir.path().AppendASCII("create_file_1");
 
   // Create a file.
   bool created = false;
   base::PlatformFileError error_code = base::PLATFORM_FILE_OK;
   base::PlatformFile file = base::CreatePlatformFile(
       file_path,
-      base::PLATFORM_FILE_OPEN_ALWAYS |
-      base::PLATFORM_FILE_READ |
-      base::PLATFORM_FILE_SHARE_DELETE,
-      &created, &error_code);
+      base::PLATFORM_FILE_OPEN_ALWAYS | base::PLATFORM_FILE_READ |
+          base::PLATFORM_FILE_SHARE_DELETE,
+      &created,
+      &error_code);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
   EXPECT_TRUE(created);
   EXPECT_EQ(base::PLATFORM_FILE_OK, error_code);
 
   // Open an existing file and mark it as delete on close.
   created = false;
   base::PlatformFile same_file = base::CreatePlatformFile(
       file_path,
-      base::PLATFORM_FILE_OPEN |
-      base::PLATFORM_FILE_DELETE_ON_CLOSE |
-      base::PLATFORM_FILE_READ,
-      &created, &error_code);
+      base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_DELETE_ON_CLOSE |
+          base::PLATFORM_FILE_READ,
+      &created,
+      &error_code);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
   EXPECT_FALSE(created);
   EXPECT_EQ(base::PLATFORM_FILE_OK, error_code);
 
   // Close both handles and check that the file is gone.
   base::ClosePlatformFile(file);
   base::ClosePlatformFile(same_file);
   EXPECT_FALSE(file_util::PathExists(file_path));
 }
 
 TEST(PlatformFile, ReadWritePlatformFile) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   FilePath file_path = temp_dir.path().AppendASCII("read_write_file");
   base::PlatformFile file = base::CreatePlatformFile(
       file_path,
-      base::PLATFORM_FILE_CREATE |
-      base::PLATFORM_FILE_READ |
-      base::PLATFORM_FILE_WRITE,
-      NULL, NULL);
+      base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_READ |
+          base::PLATFORM_FILE_WRITE,
+      NULL,
+      NULL);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
 
   char data_to_write[] = "test";
   const int kTestDataSize = 4;
 
   // Write 0 bytes to the file.
   int bytes_written = WriteFully(file, 0, data_to_write, 0);
   EXPECT_EQ(0, bytes_written);
 
   // Write "test" to the file.
@@ skipping 49 matching lines @@
     EXPECT_EQ(data_to_write[i], data_read_2[i]);
   for (int i = kTestDataSize; i < kOffsetBeyondEndOfFile; i++)
     EXPECT_EQ(0, data_read_2[i]);
   for (int i = kOffsetBeyondEndOfFile; i < file_size; i++)
     EXPECT_EQ(data_to_write[i - kOffsetBeyondEndOfFile], data_read_2[i]);
 
   // Close the file handle to allow the temp directory to be deleted.
   base::ClosePlatformFile(file);
 }
 
+TEST(PlatformFile, AppendPlatformFile) {
+  base::ScopedTempDir temp_dir;
+  ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+  FilePath file_path = temp_dir.path().AppendASCII("append_file");
+  base::PlatformFile file = base::CreatePlatformFile(
+      file_path,
+      base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_APPEND,
+      NULL,
+      NULL);
+  EXPECT_NE(base::kInvalidPlatformFileValue, file);
+
+  char data_to_write[] = "test";
+  const int kTestDataSize = 4;
+
+  // Write 0 bytes to the file.
+  int bytes_written = WriteFully(file, 0, data_to_write, 0);
+  EXPECT_EQ(0, bytes_written);
+
+  // Write "test" to the file.
+  bytes_written = WriteFully(file, 0, data_to_write, kTestDataSize);
+  EXPECT_EQ(kTestDataSize, bytes_written);
+
+  base::ClosePlatformFile(file);
+  file = base::CreatePlatformFile(
+      file_path,
+      base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ |
+          base::PLATFORM_FILE_APPEND,
+      NULL,
+      NULL);
+  EXPECT_NE(base::kInvalidPlatformFileValue, file);
+  if (file == base::kInvalidPlatformFileValue) {
+    printf("errno: %d\n", errno);
+  }
+
+  char append_data_to_write[] = "78";
+  const int kAppendDataSize = 2;
+
+  // Append "test" to the file.
+  bytes_written = WriteFully(file, 0, append_data_to_write, kAppendDataSize);
+  EXPECT_EQ(2, bytes_written);
+
+  // Read the entire file.
+  char data_read_1[32];
+  int bytes_read = ReadFully(file, 0, data_read_1,
+                             kTestDataSize + kAppendDataSize);
+  EXPECT_EQ(6, bytes_read);
+
+  // Close the file handle to allow the temp directory to be deleted.
+  base::ClosePlatformFile(file);
+}
+
+
 TEST(PlatformFile, TruncatePlatformFile) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   FilePath file_path = temp_dir.path().AppendASCII("truncate_file");
   base::PlatformFile file = base::CreatePlatformFile(
       file_path,
-      base::PLATFORM_FILE_CREATE |
-      base::PLATFORM_FILE_READ |
-      base::PLATFORM_FILE_WRITE,
-      NULL, NULL);
+      base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_READ |
+          base::PLATFORM_FILE_WRITE,
+      NULL,
+      NULL);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
 
   // Write "test" to the file.
   char data_to_write[] = "test";
   int kTestDataSize = 4;
   int bytes_written = WriteFully(file, 0, data_to_write, kTestDataSize);
   EXPECT_EQ(kTestDataSize, bytes_written);
 
   // Extend the file.
   const int kExtendedFileLength = 10;
@@ skipping 30 matching lines @@
 // Flakily fails: http://crbug.com/86494
 #if defined(OS_ANDROID)
 TEST(PlatformFile, TouchGetInfoPlatformFile) {
 #else
 TEST(PlatformFile, DISABLED_TouchGetInfoPlatformFile) {
 #endif
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::PlatformFile file = base::CreatePlatformFile(
       temp_dir.path().AppendASCII("touch_get_info_file"),
-      base::PLATFORM_FILE_CREATE |
-      base::PLATFORM_FILE_WRITE |
-      base::PLATFORM_FILE_WRITE_ATTRIBUTES,
-      NULL, NULL);
+      base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_WRITE |
+          base::PLATFORM_FILE_WRITE_ATTRIBUTES,
+      NULL,
+      NULL);
   EXPECT_NE(base::kInvalidPlatformFileValue, file);
 
   // Get info for a newly created file.
   base::PlatformFileInfo info;
   EXPECT_TRUE(base::GetPlatformFileInfo(file, &info));
 
   // Add 2 seconds to account for possible rounding errors on
   // filesystems that use a 1s or 2s timestamp granularity.
   base::Time now = base::Time::Now() + base::TimeDelta::FromSeconds(2);
   EXPECT_EQ(0, info.size);
@@ skipping 40 matching lines @@
   EXPECT_EQ(info.last_modified.ToInternalValue(),
             new_last_modified.ToInternalValue());
 #endif
 
   EXPECT_EQ(info.creation_time.ToInternalValue(),
             creation_time.ToInternalValue());
 
   // Close the file handle to allow the temp directory to be deleted.
   base::ClosePlatformFile(file);
 }