Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1586073004: [MD settings] PrivacyAndSecurity settings closer to mocks (Closed)

Created:
4 years, 11 months ago by dschuyler
Modified:
4 years, 11 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] PrivacyAndSecurity settings closer to mocks This CL 1. fixes some misalignment of the Manage certificates and Site settings rows in the Privacy & Security section. 2. Adds a .secondary class for .settings-box for secondary text. 3. Adds some placeholder Lorum Ipsum like text that is in the mock, but I'm confident will need to change - thus I didn't add a .grd entry for the text and inlined it instead. Before: http://imgur.com/1N6lx1c After: http://imgur.com/CBH7seH BUG=517564 Committed: https://crrev.com/35336de9cf087aaa33e77f90c1f6f7dfb3842ddd Cr-Commit-Position: refs/heads/master@{#369810}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 1 chunk +14 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dschuyler
4 years, 11 months ago (2016-01-15 00:46:28 UTC) #3
dpapad
lgtm https://codereview.chromium.org/1586073004/diff/1/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/1586073004/diff/1/chrome/browser/resources/settings/privacy_page/privacy_page.html#newcode77 chrome/browser/resources/settings/privacy_page/privacy_page.html:77: Contrary to popular belief, Lorem Ipsum is not ...
4 years, 11 months ago (2016-01-15 01:16:33 UTC) #4
dschuyler
Added comment.
4 years, 11 months ago (2016-01-15 01:20:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586073004/20001
4 years, 11 months ago (2016-01-15 19:19:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 19:28:27 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 19:30:23 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35336de9cf087aaa33e77f90c1f6f7dfb3842ddd
Cr-Commit-Position: refs/heads/master@{#369810}

Powered by Google App Engine
This is Rietveld 408576698