Issue 1586043005: Check comparison tag before checking attributes in IfThenElseInstr::AttributesEqual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1586043005: Check comparison tag before checking attributes in IfThenElseInstr::AttributesEqual. (Closed)

Created:
4 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
4 years, 11 months ago

Reviewers:
Florian Schneider, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Check comparison tag before checking attributes in IfThenElseInstr::AttributesEqual. AttributesEqual must only be invoked on the instructions of the same type. R=fschneider@google.com, rmacnak@google.com BUG=http://dartbug.com/25422 Committed: https://github.com/dart-lang/sdk/commit/a3e42b6f7b114e6600e0687872536a6be4caebf6

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/intermediate_language.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Vyacheslav Egorov (Google)

4 years, 11 months ago (2016-01-15 19:37:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3e42b6f7b114e6600e0687872536a6be4caebf6 (presubmit successful).