Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 1586043003: media: Require HW_SECURE_CODECS for other key systems on Android. (Closed)

Created:
4 years, 11 months ago by xhwang
Modified:
4 years, 11 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Require HW_SECURE_CODECS for other key systems on Android. On Android, for Widevine we know when hardware secure codecs are required based on robustness level. For Clear Key, it's never required. All other key systems that we know of requires hardware secure codecs. Setting this assumption in the code. Note that this CL depends on http://chromiumcodereview.appspot.com/1585083003/ BUG=577777 Committed: https://crrev.com/d63955e64530163c0c3119e08b60053034e99f19 Cr-Commit-Position: refs/heads/master@{#369697}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M media/base/key_systems.cc View 2 chunks +9 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (5 generated)
xhwang
PTAL https://chromiumcodereview.appspot.com/1586043003/diff/1/media/base/key_systems.cc File media/base/key_systems.cc (right): https://chromiumcodereview.appspot.com/1586043003/diff/1/media/base/key_systems.cc#newcode810 media/base/key_systems.cc:810: robustness >= EmeRobustness::SW_SECURE_DECODE) || I changed this to ...
4 years, 11 months ago (2016-01-15 01:19:04 UTC) #2
ddorwin
lgtm https://chromiumcodereview.appspot.com/1586043003/diff/1/media/base/key_systems.cc File media/base/key_systems.cc (right): https://chromiumcodereview.appspot.com/1586043003/diff/1/media/base/key_systems.cc#newcode810 media/base/key_systems.cc:810: robustness >= EmeRobustness::SW_SECURE_DECODE) || On 2016/01/15 01:19:04, xhwang ...
4 years, 11 months ago (2016-01-15 01:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586043003/1
4 years, 11 months ago (2016-01-15 05:53:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 07:03:19 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 07:04:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d63955e64530163c0c3119e08b60053034e99f19
Cr-Commit-Position: refs/heads/master@{#369697}

Powered by Google App Engine
This is Rietveld 408576698