src/x87/code-stubs-x87.cc - Issue 1586013006: X87: [turbofan] avoid xchg instruction on Intel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/code-stubs-x87.cc

Issue 1586013006: X87: [turbofan] avoid xchg instruction on Intel. Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x87/code-stubs-x87.cc

diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc

index 1da5f41a8865f5744d0379fab10983974f9ea053..816c18988e23f8b9fafc2f8295ea9113c59f883e 100644

--- a/src/x87/code-stubs-x87.cc

+++ b/src/x87/code-stubs-x87.cc

@@ -3051,7 +3051,9 @@ void CompareICStub::GenerateBooleans(MacroAssembler* masm) {

__ AssertSmi(eax);

__ mov(edx, FieldOperand(edx, Oddball::kToNumberOffset));

__ AssertSmi(edx);

- __ xchg(eax, edx);

+ __ push(eax);

+ __ mov(eax, edx);

+ __ pop(edx);

}

__ sub(eax, edx);

__ Ret();

« no previous file with comments | « src/crankshaft/x87/lithium-gap-resolver-x87.cc ('k') | no next file » | no next file with comments »