Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1772)

Unified Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1585973004: Use constructor args in favor of summary "encode" functions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/public_namespace_computer.dart
diff --git a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
index a0a474f2cb879f4689b8f16a1259d55e7996ab4b..6de2ec848d8c612ba7f61ef1f72a045acc164825 100644
--- a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
+++ b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
@@ -14,7 +14,7 @@ import 'package:analyzer/src/summary/format.dart';
UnlinkedPublicNamespaceBuilder computePublicNamespace(CompilationUnit unit) {
_PublicNamespaceVisitor visitor = new _PublicNamespaceVisitor();
unit.accept(visitor);
- return encodeUnlinkedPublicNamespace(
+ return new UnlinkedPublicNamespaceBuilder(
names: visitor.names, exports: visitor.exports, parts: visitor.parts);
}
@@ -26,12 +26,12 @@ class _CombinatorEncoder extends SimpleAstVisitor<UnlinkedCombinatorBuilder> {
@override
UnlinkedCombinatorBuilder visitHideCombinator(HideCombinator node) {
- return encodeUnlinkedCombinator(hides: encodeNames(node.hiddenNames));
+ return new UnlinkedCombinatorBuilder(hides: encodeNames(node.hiddenNames));
}
@override
UnlinkedCombinatorBuilder visitShowCombinator(ShowCombinator node) {
- return encodeUnlinkedCombinator(shows: encodeNames(node.shownNames));
+ return new UnlinkedCombinatorBuilder(shows: encodeNames(node.shownNames));
}
}
@@ -46,7 +46,7 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
void addNameIfPublic(
String name, PrelinkedReferenceKind kind, int numTypeParameters) {
if (isPublic(name)) {
- names.add(encodeUnlinkedPublicName(
+ names.add(new UnlinkedPublicNameBuilder(
name: name, kind: kind, numTypeParameters: numTypeParameters));
}
}
@@ -72,7 +72,7 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
@override
visitExportDirective(ExportDirective node) {
- exports.add(encodeUnlinkedExportPublic(
+ exports.add(new UnlinkedExportPublicBuilder(
uri: node.uri.stringValue,
combinators: node.combinators
.map((Combinator c) => c.accept(new _CombinatorEncoder()))
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698