Use constructor args in favor of summary "encode" functions.

pkg/analyzer/tool/summary/generate.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file contains code to generate serialization/deserialization logic for
  * summaries based on an "IDL" description of the summary format (written in
  * stylized Dart).
  *
  * For each class in the "IDL" input, two corresponding classes are generated:
@@ skipping 255 matching lines @@
       out('enum $name {');
       indent(() {
         for (String value in enm.values) {
           out('$value,');
         }
       });
       out('}');
       out();
     });
     for (var cls in _idl.classes.values) {
-      List<String> builderParams = _generateBuilder(cls);
-      out();
-      _generateEncodeFunction(cls, builderParams);
+      _generateBuilder(cls);
       out();
       _generateInterface(cls);
       out();
       _generateReader(cls);
       out();
       _generateImpl(cls);
       out();
       _generateMixin(cls);
       out();
     }
   }
 
   /**
    * Enclose [s] in quotes, escaping as necessary.
    */
   String quoted(String s) {
     return JSON.encode(s);
   }
 
-  List<String> _generateBuilder(idlModel.ClassDeclaration cls) {
+  void _generateBuilder(idlModel.ClassDeclaration cls) {
     String name = cls.name;
     String builderName = name + 'Builder';
     String mixinName = '_${name}Mixin';
-    List<String> builderParams = <String>[];
+    List<String> constructorParams = <String>[];
     out('class $builderName extends Object with $mixinName '
         'implements $name {');
     indent(() {
       out('bool _finished = false;');
       // Generate fields.
       out();
       for (idlModel.FieldDeclaration field in cls.fields) {
         String fieldName = field.name;
         idlModel.FieldType type = field.type;
         String typeStr = encodedType(type);
         out('$typeStr _$fieldName;');
       }
-      // Generate constructor.
-      out();
-      out('$builderName();');
       // Generate getters and setters.
       for (idlModel.FieldDeclaration field in cls.fields) {
         String fieldName = field.name;
         String typeStr = encodedType(field.type);
         String def = defaultValue(field.type);
         String defSuffix = def == null ? '' : ' ?? $def';
         out();
         out('@override');
         out('${dartType(field.type)} get $fieldName => _$fieldName$defSuffix;');
         out();
         outDoc(field.documentation);
-        builderParams.add('$typeStr $fieldName');
+        constructorParams.add('$typeStr $fieldName');
         out('void set $fieldName($typeStr _value) {');
         indent(() {
           String stateFieldName = '_' + fieldName;
           out('assert(!_finished);');
           out('$stateFieldName = _value;');
         });
         out('}');
       }
+      // Generate constructor.
+      out();
+      out('$builderName({${constructorParams.join(', ')}})');
+      for (int i = 0; i < cls.fields.length; i++) {
+        idlModel.FieldDeclaration field = cls.fields[i];
+        String prefix = i == 0 ? '  : ' : '    ';
+        String suffix = i == cls.fields.length - 1 ? ';' : ',';
+        out('${prefix}_${field.name} = ${field.name}$suffix');
+      }
       // Generate finish.
       if (cls.isTopLevel) {
         out();
         out('List<int> toBuffer() {');
         indent(() {
           out('fb.Builder fbBuilder = new fb.Builder();');
           out('return fbBuilder.finish(finish(fbBuilder));');
         });
         out('}');
       }
@@ skipping 79 matching lines @@
           indent(() {
             out(writeCode);
           });
           out('}');
         });
         out('return fbBuilder.endTable();');
       });
       out('}');
     });
     out('}');
-    return builderParams;
-  }
-
-  void _generateEncodeFunction(
-      idlModel.ClassDeclaration cls, List<String> builderParams) {
-    String className = cls.name;
-    String builderName = className + 'Builder';
-    out('$builderName encode$className({${builderParams.join(', ')}}) {');
-    indent(() {
-      out('$builderName builder = new $builderName();');
-      for (idlModel.FieldDeclaration field in cls.fields) {
-        String fieldName = field.name;
-        out('builder.$fieldName = $fieldName;');
-      }
-      out('return builder;');
-    });
-    out('}');
   }
 
   void _generateImpl(idlModel.ClassDeclaration cls) {
     String name = cls.name;
     String implName = '_${name}Impl';
     String mixinName = '_${name}Mixin';
     out('class $implName extends Object with $mixinName implements $name {');
     indent(() {
       out('final fb.BufferPointer _bp;');
       out();
@@ skipping 129 matching lines @@
       return token.lexeme.split('\n').map((String line) {
         if (line.startsWith(indent)) {
           line = line.substring(indent.length);
         }
         return line;
       }).join('\n');
     }
     return null;
   }
 }