Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1585973004: Use constructor args in favor of summary "encode" functions. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use constructor args in favor of summary "encode" functions. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ba31abe42941c619ed98237254316a4bd843eec4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -382 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 75 chunks +172 lines, -297 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 7 chunks +10 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 16 chunks +28 lines, -24 lines 0 comments Download
M pkg/analyzer/test/src/summary/name_filter_test.dart View 14 chunks +20 lines, -20 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 6 chunks +13 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-14 16:50:57 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-14 16:53:48 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-14 17:30:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba31abe42941c619ed98237254316a4bd843eec4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698