Settings People Revamp: Add tests for ChromeOS Change Picture.

chrome/browser/resources/settings/people_page/change_picture.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+var changePictureOptions = changePictureOptions || {

[dpapad, 2016/01/19 19:44:59]

Is there a way we can avoid this global variable? Can we turn it into a member
variable of the custom element instead?

[tommycli, 2016/01/20 00:30:27]

I could not figure out an alternative. I followed the example here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

Is there a way to declare static variables on Polymer elements? This relies on
the fact that the test has a chance to declare the global BEFORE polymer does.

[dpapad, 2016/01/20 01:09:29]

Two ways I can think of.
1) Don't test that the URL actually changes. Instead just test that
receiveSelectedImage() is being called with the new URL.
2) Keep testing selectedImageUrl_ via the change notification but define a
namespace for the global config var,
   cr.define('settings_test', function() {
     var changePictureOptions = ......;
     return {changePictureOptions: changePictureOptions};
   });

[tommycli, 2016/01/20 22:38:12]

Done.

Okay cool! i was able to namespace it to settings_test! In the future I might
choose to take Option a) instead.

Thanks!

+  /**
+   * True if property changes should fire events for testing purposes.
+   * @type {boolean}
+   */
+  notifyPropertyChangesForTest: false,
+};
+
 /**
  * @fileoverview
  * 'settings-change-picture' is the settings subpage containing controls to
  * edit a ChromeOS user's picture.
  *
  * @group Chrome Settings Elements
  * @element settings-change-picture
  */
 Polymer({
   is: 'settings-change-picture',
 
   behaviors: [
     I18nBehavior,
   ],
 
   properties: {
     /**
      * The currently selected profile image URL. May be a data URL.
      * @private {string}
      */
-    selectedImageUrl_: String,
+    selectedImageUrl_: {
+      type: String,
+      notify: changePictureOptions.notifyPropertyChangesForTest,
+    },
 
     /**
      * The url of the 'old' image, which is the existing image sourced from
      * the camera, a file, or a deprecated default image.
      * @private {string}
      */
     oldImageUrl_: String,
 
     /**
      * The url of the profile image.
@@ skipping 123 matching lines @@
    * Computed binding determining which profile image button is toggled on.
    * @private
    * @param {string} imageUrl
    * @param {string} selectedImageUrl
    * @return {boolean}
    */
   isActiveImage_: function(imageUrl, selectedImageUrl) {
     return imageUrl == selectedImageUrl;
   },
 });