Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: ui/base/template_expressions_unittest.cc

Issue 1585923011: [Template Expressions] changing ${ leader to $i18n{ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for $i18n comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/template_expressions.cc ('k') | ui/base/webui/web_ui_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/template_expressions_unittest.cc
diff --git a/ui/base/template_expressions_unittest.cc b/ui/base/template_expressions_unittest.cc
index b56a5e7424c25e80a4cfc10e4d853de564608a11..947f253997c8d3f5cc08459df15f466b06cf7774 100644
--- a/ui/base/template_expressions_unittest.cc
+++ b/ui/base/template_expressions_unittest.cc
@@ -9,27 +9,26 @@
namespace ui {
TEST(TemplateExpressionsTest, ReplaceTemplateExpressionsPieces) {
- std::map<base::StringPiece, std::string> substitutions;
+ TemplateReplacements substitutions;
substitutions["test"] = "word";
substitutions["5"] = "number";
- EXPECT_EQ("${}", ReplaceTemplateExpressions("${}", substitutions));
EXPECT_EQ("", ReplaceTemplateExpressions("", substitutions));
- EXPECT_EQ("word", ReplaceTemplateExpressions("${test}", substitutions));
- EXPECT_EQ("number ", ReplaceTemplateExpressions("${5} ", substitutions));
- EXPECT_EQ(
- "multiple: word, number.",
- ReplaceTemplateExpressions("multiple: ${test}, ${5}.", substitutions));
+ EXPECT_EQ("word", ReplaceTemplateExpressions("$i18n{test}", substitutions));
+ EXPECT_EQ("number ", ReplaceTemplateExpressions("$i18n{5} ", substitutions));
+ EXPECT_EQ("multiple: word, number.",
+ ReplaceTemplateExpressions("multiple: $i18n{test}, $i18n{5}.",
+ substitutions));
}
TEST(TemplateExpressionsTest,
ReplaceTemplateExpressionsConsecutiveDollarSignsPieces) {
- std::map<base::StringPiece, std::string> substitutions;
+ TemplateReplacements substitutions;
substitutions["a"] = "x";
EXPECT_EQ("$ $$ $$$", ReplaceTemplateExpressions("$ $$ $$$", substitutions));
- EXPECT_EQ("$x", ReplaceTemplateExpressions("$${a}", substitutions));
- EXPECT_EQ("$$x", ReplaceTemplateExpressions("$$${a}", substitutions));
- EXPECT_EQ("$12", ReplaceTemplateExpressions("$12", substitutions));
+ EXPECT_EQ("$x", ReplaceTemplateExpressions("$$i18n{a}", substitutions));
+ EXPECT_EQ("$$x", ReplaceTemplateExpressions("$$$i18n{a}", substitutions));
+ EXPECT_EQ("$i18n12", ReplaceTemplateExpressions("$i18n12", substitutions));
}
} // namespace ui
« no previous file with comments | « ui/base/template_expressions.cc ('k') | ui/base/webui/web_ui_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698