chrome/browser/web_dev_style/css_checker_test.py - Issue 1585923011: [Template Expressions] changing ${ leader to $i18n{

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_dev_style/css_checker_test.py

Issue 1585923011: [Template Expressions] changing ${ leader to $i18n{ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix for $i18n comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_dev_style/css_checker_test.py

diff --git a/chrome/browser/web_dev_style/css_checker_test.py b/chrome/browser/web_dev_style/css_checker_test.py

index 0d3f00745b452188886b3d627b6d54a5c7c0909e..156bb44f9c27b3e5005369be5a5709fb6d2cc84e 100755

--- a/chrome/browser/web_dev_style/css_checker_test.py

+++ b/chrome/browser/web_dev_style/css_checker_test.py

@@ -185,8 +185,8 @@ blah /* hey! */

100% { height: 500px; }

}

-#id { /* ${TemplateExpressions} should be ignored. */

- rule: ${someValue};

+#id { /* $i18n{TemplateExpressions} should be ignored. */

+ rule: $i18n{someValue};

--css-mixin: {

color: red;

};

« no previous file with comments | « chrome/browser/web_dev_style/css_checker.py ('k') | ui/base/template_expressions.h » ('j') | no next file with comments »