ui/base/template_expressions.h - Issue 1585923011: [Template Expressions] changing ${ leader to $i18n{

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/template_expressions.h

Issue 1585923011: [Template Expressions] changing ${ leader to $i18n{ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/template_expressions.h

diff --git a/ui/base/template_expressions.h b/ui/base/template_expressions.h

index ff14ee1b719149e0286a24c728ec4b64a28a8d35..e0b50fb04ba94fef8752dd28a93e5cb0d145b8b8 100644

--- a/ui/base/template_expressions.h

+++ b/ui/base/template_expressions.h

@@ -16,12 +16,15 @@

namespace ui {

+// Map of strings for template replacement in |ReplaceTemplateExpressions|.

+typedef std::map<const std::string, std::string> ReplaceTemplateMap;

Dan Beam 2016/01/20 22:34:38 nit: I18nTemplateMap? TemplateReplacements? Templa

dschuyler 2016/01/21 18:43:53 Done.

// Replace ${foo} in the format string with the value for the foo key in

// |subst|. If the key is not found in the |substitutions| that item will

// be unaltered.

UI_BASE_EXPORT std::string ReplaceTemplateExpressions(

base::StringPiece format_string,

- const std::map<base::StringPiece, std::string>& substitutions);

+ const ReplaceTemplateMap& substitutions);

} // namespace ui

« no previous file with comments | « chrome/browser/web_dev_style/css_checker.py ('k') | ui/base/template_expressions.cc » ('j') | ui/base/template_expressions.cc » ('J')