Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1585923010: dart2js cps: Eliminate duplicate branches. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unneeded change #

Patch Set 3 : Add missing type annotations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -10 lines) Patch
A pkg/compiler/lib/src/cps_ir/duplicate_branch.dart View 1 2 1 chunk +123 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/argument_refinement_21.js View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 11 months ago (2016-01-15 23:04:59 UTC) #2
sra1
lgtm
4 years, 11 months ago (2016-01-16 00:24:58 UTC) #3
asgerf
4 years, 11 months ago (2016-01-16 00:43:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
eab396d82b2db4d34f3bc365cddd853ad3e56f01 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698